Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

target-size must check whether nearby elements are obscured #4387

Closed
WilcoFiers opened this issue Mar 27, 2024 · 1 comment · Fixed by #4422 · 4 remaining pull requests
Closed

target-size must check whether nearby elements are obscured #4387

WilcoFiers opened this issue Mar 27, 2024 · 1 comment · Fixed by #4422 · 4 remaining pull requests
Assignees
@straker
Labels
fix Bug fixes rules Issue or false result from an axe-core rule support target-size
Milestone
Axe-core 4.9.1

Comments

@WilcoFiers
Copy link
Contributor

WilcoFiers commented Mar 27, 2024 •
edited
Loading

The "Accept all cookies" link should not fail. The nearby "go to top" link is obscured:

<div style="position: fixed; bottom: 0">
  <a href="#">Go to top</a>
</div>
<div style="position: fixed; bottom: 0; left: 0; right: 0; background: #eee">
  Cookies: <a href="#">Accept all cookies</a>
</div>

Note There are open issues related to this. Review them and keep them in mind when working on this.
@WilcoFiers WilcoFiers added fix Bug fixes rules Issue or false result from an axe-core rule support target-size labels Mar 27, 2024
@WilcoFiers WilcoFiers added this to the Axe-core 4.10 milestone Mar 27, 2024
@straker straker mentioned this issue Apr 22, 2024
Merged
straker added a commit that referenced this issue Apr 23, 2024
@straker
fix(target-size): pass for element that has nearby elements that are …
3a90bb7 
…obscured (#4422)

Had to update how we handled the too many rects break early since it
would return an empty array, which when looking at the lengths of the
arrays in `getOffset` made it difficult to know which case needed to be
handled (returned empty due to too many rects or returned empty because
there wasn't any visible rect). Talked to Wilco and we agreed that when
we encountered too many rects we could throw and handle the error case
in both checks.

Closes: #4387
@attest-team-ci attest-team-ci mentioned this issue May 6, 2024
Merged
WilcoFiers added a commit that referenced this issue May 6, 2024
@WilcoFiers
chore(release): v4.9.1 (#4446)
fff9b9d 
###
[4.9.1](v4.9.0...v4.9.1)
(2024-05-06)

### Bug Fixes

- Prevent errors when loading axe in a page with prototype.js
- **aria-allowed-attr:** allow meter role allowed aria-\* attributes on
meter element
([#4435](#4435))
([7ac6392](7ac6392))
- **aria-allowed-role:** add gridcell, separator, slider and treeitem to
allowed roles of button element
([#4398](#4398))
([4788bf8](4788bf8))
- **aria-roles:** correct abstract roles (types) for
aria-roles([#4421](#4421))
- **aria-valid-attr-value:** aria-controls & aria-haspopup incomplete
([#4418](#4418))
- fix building axe-core translation files with region locales
([#4396](#4396))
([5c318f3](5c318f3)),
closes [#4388](#4388)
- **invalidrole:** allow upper and mixed case role names
([#4358](#4358))
([105016c](105016c)),
closes [#2695](#2695)
- **isVisibleOnScreen:** account for position: absolute elements inside
overflow container
([#4405](#4405))
([2940f6e](2940f6e)),
closes [#4016](#4016)
- **label-content-name-mismatch:** better dismiss and wysiwyg symbolic
text characters
([#4402](#4402))
- **region:** Decorative images ignored by region rule
([#4412](#4412))
- **target-size:** ignore descendant elements in shadow dom
([#4410](#4410))
([6091367](6091367))
- **target-size:** pass for element that has nearby elements that are
obscured ([#4422](#4422))
([3a90bb7](3a90bb7)),
closes [#4387](#4387)


This PR was opened by a robot 🤖 🎉 (And updated by @WilcoFiers
)
@padmavemulapati
Copy link

Verified with the latest axe-core-develop branch code base,
target-size rule ignores and obscured for the elements nearby , findings can be in passes

image

@data-sync-user data-sync-user mentioned this issue Jun 3, 2024
Merged
@wingn8t wingn8t mentioned this issue Jun 14, 2024
Open
@gurudeep9 gurudeep9 mentioned this issue Jun 23, 2024
Open
@abdulrahman305 abdulrahman305 mentioned this issue Jul 3, 2024
Open
@Stanislav1975 Stanislav1975 mentioned this issue Aug 9, 2024
Open
@Stanislav1975 Stanislav1975 mentioned this issue Aug 19, 2024
Open
@Stanislav1975 Stanislav1975 mentioned this issue Sep 9, 2024
Open
@organich organich mentioned this issue Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@straker straker

Labels
fix Bug fixes rules Issue or false result from an axe-core rule support target-size
Projects
None yet
Milestone
Axe-core 4.9.1
Development

Successfully merging a pull request may close this issue.

fix(target-size): pass for element that has nearby elements that are obscured dequelabs/axe-core
[Snyk] Upgrade axe-core from 4.8.4 to 4.9.1 wingn8t/wagtail
[Snyk] Upgrade axe-core from 4.9.0 to 4.9.1 gurudeep9/mattermost-test
[Snyk] Upgrade axe-core from 4.7.2 to 4.9.1 abdulrahman305/docs
[Snyk] Upgrade axe-core from 4.3.3 to 4.9.1 Stanislav1975/sitespeed.io
[Snyk] Upgrade axe-core from 4.3.3 to 4.10.0 Stanislav1975/sitespeed.io
[Snyk] Upgrade: uuid, , , axe-core, fast-stats, find-up, cli-color, coach-core, dayjs, fs-extra, influx, jstransformer-markdown-it, junit-report-builder, os-name, p-limit, pug, recursive-readdir Stanislav1975/sitespeed.io
[Snyk] Upgrade axe-core from 4.4.1 to 4.10.0 organich/lighthouse
3 participants
@WilcoFiers @straker @padmavemulapati