Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Axe reporter is very slow with large datasets #512

Closed
WilcoFiers opened this issue Sep 7, 2017 · 1 comment
Closed

Axe reporter is very slow with large datasets #512

WilcoFiers opened this issue Sep 7, 2017 · 1 comment
Assignees
@WilcoFiers
Labels
support

Comments

@WilcoFiers
Copy link
Contributor

On extremely large pages, it is possible for the reporter to take several times longer than the actual audit to complete. The main problem appears to be in helpers.processAggregate(). Running it 30 000 times took several minutes to complete. Part of the issue here is that the extension is hugely inefficient here because it's processing passes, which won't actually get displayed.

Part of the solution should be in preventing that. But there's certainly an extra problem. The method doesn't (or at least shouldn't) do anything that's particularly slow, so we need to figure out what's so slow and we should fix it.

This problem can be reproduced on the following page:
https://dev.office.com/fabric#/components/detailslist
@WilcoFiers WilcoFiers self-assigned this Sep 7, 2017
isner added a commit that referenced this issue Oct 10, 2017
@isner
perf(reporter): add option to limit result types to be processed
17f289f 
Closes #512 #512
@isner isner mentioned this issue Oct 10, 2017
Merged
@isner
Copy link
Contributor

isner commented Oct 10, 2017

Fixed by #568, provided the implementation uses the new 'resultTypes' options (see PR).

isner added a commit that referenced this issue Oct 13, 2017
@isner
perf(reporter): add option to limit result types to be processed
78543b4 
Closes #512 #512
isner added a commit that referenced this issue Oct 17, 2017
@isner
docs(resultTypes): add documentation for resultTypes option, and fix …
2a56071 
…a small doc error

Related to #512
WilcoFiers pushed a commit that referenced this issue Oct 18, 2017
@isner @WilcoFiers
perf(reporter): add option to limit result types to be processed (#568)
42b46d9 
* perf(reporter): add option to limit result types to be processed

Closes #512 #512

* docs(resultTypes): add documentation for resultTypes option, and fix a small doc error

Related to #512
mrtnvh pushed a commit to mrtnvh/axe-core that referenced this issue Nov 24, 2023
@dependabot
chore(deps): bump ansi-regex from 3.0.0 to 3.0.1 in /packages/webdriv…
1d02d7b 
…erjs/tests/example (dequelabs#512)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WilcoFiers WilcoFiers

Labels
support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WilcoFiers @isner