Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TH in layout table when table has role=presentation #561

Closed
spanchang opened this issue Oct 6, 2017 · 4 comments
Closed

TH in layout table when table has role=presentation #561

spanchang opened this issue Oct 6, 2017 · 4 comments
Labels
help wanted We welcome PRs or discussions for issues marked as help wanted

Comments

@spanchang
Copy link

spanchang commented Oct 6, 2017

Gokhan Boybek reported on 10/06/17 that
Assure/Fireeyes is reporting a failure when a layout table contains <th> elements. Ok this is clearly a failure of 1.3.1 (https://www.w3.org/TR/WCAG20-TECHS/F46.html)
But it is called out as a failure even when the table contains role="presentation". Isn't that a false positive? Because the aria specs (see at http://www.w3.org/TR/wai-aria-practices-1.1/#presentation_role) clearly indicates that if role="presentation" is applied to the

tag, the descendants (including <th>) inherit this role as well.
So the client is questioning why Fireeyes is reporting this as a defect when the table tag had role="presentation", which is inherited by the th tag.

Sailesh: I agree, this is not a failure and should not be reported.

@WilcoFiers
Copy link
Contributor

That would make sense. Can you test with VoiceOver, NVDA and JAWS to make sure tables with role=presentation or role=none get ignored even if they have th / caption / scope="" on them?

@WilcoFiers WilcoFiers added the help wanted We welcome PRs or discussions for issues marked as help wanted label Oct 8, 2017
@spanchang
Copy link
Author

spanchang commented Oct 9, 2017 via email

@marcysutton
Copy link
Contributor

Just to confirm the rule that failed, was it th-has-data-cells?

@marcysutton
Copy link
Contributor

It was layout-table that failed. That scenario was already fixed with #828, so I'm going to close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted We welcome PRs or discussions for issues marked as help wanted
Projects
None yet
Development

No branches or pull requests

3 participants