perf(reporter): add option to limit result types to be processed #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
reviewed
Oct 11, 2017
|
@WilcoFiers Tests added. Let me know if the documentation is insufficient. |
…a small doc error Related to #512
isner
commented
Oct 17, 2017
| @@ -231,7 +231,7 @@ axe.run(context, options, callback); | |||
| #### Parameters axe.run | |||
|
|
|||
| * [`context`](#context-parameter): (optional) Defines the scope of the analysis - the part of the DOM that you would like to analyze. This will typically be the `document` or a specific selector such as class name, ID, selector, etc. | |||
| * [`options`](#options-parameter): (optional) Set of options passed into rules or checks, temporarily modifying them. This contrasts with `axe.configure`, which is more permanent. [See below for more information](#axerun-parameters) | |||
There was a problem hiding this comment.
The documentation for axe.configure is above, not below, and the internal link is invalid. I figured we ought to simply remove this.
WilcoFiers
approved these changes
Oct 18, 2017
|
@WilcoFiers @isner did the CircleCI build run for this PR? |
|
@dylanb it says it did, you can find the integrations under "View details" on the merged commit above |
This was referenced May 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to specify a short list of result types that we want
helper.processAggregateto bother processing. For some reporting scenarios, we don't want to bother processing 'passes', for instance. This causes a massive performance improvement for those scenarios.We can leverage this option in the axe extension to speed up performance there as well.
Closes #512