Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core should allow NodeLists in relatedNodes and cast to an Array #8

Closed
dsturley opened this issue Jun 15, 2015 · 0 comments
Closed
Labels
core Issues in the core code (lib/core) feat New feature or enhancement
Milestone

Comments

@dsturley
Copy link
Contributor

Reporters assume that relatedNodes should always be an Array, not a NodeList. Engine should cast all relatedNodes to Arrays.

@dsturley dsturley added feat New feature or enhancement core Issues in the core code (lib/core) labels Jun 15, 2015
@dsturley dsturley modified the milestone: 1.1.0 Jun 15, 2015
marcysutton pushed a commit that referenced this issue Jun 27, 2016
WilcoFiers pushed a commit that referenced this issue Mar 5, 2019
## The devDependency [make-dir](https://github.com/sindresorhus/make-dir) was updated from `1.3.0` to `2.1.0`.
This version is **not covered** by your **current version range**.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

---

<details>
<summary>Release Notes for v2.1.0</summary>

<ul>
<li>Add TypeScript definition (<a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="416538580" data-permission-text="Issue title is private" data-url="sindresorhus/make-dir#11" data-hovercard-type="pull_request" data-hovercard-url="/sindresorhus/make-dir/pull/11/hovercard" href="https://urls.greenkeeper.io/sindresorhus/make-dir/pull/11">#11</a>)  <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/sindresorhus/make-dir/commit/9d1744549efa3dcb0b966a023fef0bb0597f6e65/hovercard" href="https://urls.greenkeeper.io/sindresorhus/make-dir/commit/9d1744549efa3dcb0b966a023fef0bb0597f6e65"><tt>9d17445</tt></a></li>
</ul>
<p><a class="commit-link" href="https://urls.greenkeeper.io/sindresorhus/make-dir/compare/v2.0.0...v2.1.0"><tt>v2.0.0...v2.1.0</tt></a></p>
</details>

<details>
<summary>Commits</summary>
<p>The new version differs by 9 commits.</p>
<ul>
<li><a href="https://urls.greenkeeper.io/sindresorhus/make-dir/commit/1c36213da8b2e13306ab4704ea861742bbbe7a40"><code>1c36213</code></a> <code>2.1.0</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/make-dir/commit/9d1744549efa3dcb0b966a023fef0bb0597f6e65"><code>9d17445</code></a> <code>Add TypeScript definition (#11)</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/make-dir/commit/c1294d718f3d82fd238e91ccbda08c9b6ad474e0"><code>c1294d7</code></a> <code>2.0.0</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/make-dir/commit/1e0bb2691b15ca2634b521783336fe41859b809d"><code>1e0bb26</code></a> <code>Meta tweaks</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/make-dir/commit/d1e41532c5e0d8ea9f2f9645ef8e301bc0f6b707"><code>d1e4153</code></a> <code>Use native <code>recursive</code> option when available/appropriate (#7)</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/make-dir/commit/f38a1b7216533cf02dd96dc08b29ade7f3ed9115"><code>f38a1b7</code></a> <code>Meta tweaks</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/make-dir/commit/d1d392941132c7fd891f22f13801bd547649a2e8"><code>d1d3929</code></a> <code>CI updates (#8)</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/make-dir/commit/68595e7219205054f33678f1ee5b4d50b65589fe"><code>68595e7</code></a> <code>Bump <code>pify</code> dependency (#6)</code></li>
<li><a href="https://urls.greenkeeper.io/sindresorhus/make-dir/commit/78472c0bc0e8f4e00877e176c4524382379c79a3"><code>78472c0</code></a> <code>Require Node.js 6</code></li>
</ul>
<p>See the <a href="https://urls.greenkeeper.io/sindresorhus/make-dir/compare/e962394d01198a961d42272f1e849ab601aaef1e...1c36213da8b2e13306ab4704ea861742bbbe7a40">full diff</a></p>
</details>

<details>
  <summary>FAQ and help</summary>

  There is a collection of [frequently asked questions](https://greenkeeper.io/faq.html). If those don’t help, you can always [ask the humans behind Greenkeeper](https://github.com/greenkeeperio/greenkeeper/issues/new).
</details>

---


Your [Greenkeeper](https://greenkeeper.io) bot 🌴
devaradhanm pushed a commit to devaradhanm/axe-core that referenced this issue Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues in the core code (lib/core) feat New feature or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant