-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
False positive: Angular hasbang links are being treated as in-page anchor links #824
Comments
Fair point. Thanks for reporting! |
@WilcoFiers And...? How am I gonna deal with that? It's not only Angular - it's a hashrouting thing. It's not only hashbang - it can be hashslash. Thanks |
@englishextra Both have been addressed. We're finishing up a few more things for a new release. Should be out within the next week or two. |
@WilcoFiers Very nice thanks |
Thank you for fixing this issue so quickly! |
CI: Remove schedule from auto-patch-release.yml
The new aXe plugin for Chrome displays a violation that says “the skip-link target should exist and be focusable” for any Angular links with a hashbang. I am proposing that Angular hashbang links should be excluded.
The false positive can be tested on the Angular bootstrap page:
https://ng-bootstrap.github.io/#/getting-started
Element source
ng-bootstrap
Issue description
Ensure all skip links have a focusable target
Note: this issue occurs within HTML_CodeSniffer as well and it is one of the main reasons our team moved away from CodeSniffer and started using aXe.
The text was updated successfully, but these errors were encountered: