Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive: Angular hasbang links are being treated as in-page anchor links #824

Closed
ackleyk opened this issue Apr 4, 2018 · 5 comments

Comments

@ackleyk
Copy link

ackleyk commented Apr 4, 2018

The new aXe plugin for Chrome displays a violation that says “the skip-link target should exist and be focusable” for any Angular links with a hashbang. I am proposing that Angular hashbang links should be excluded.

The false positive can be tested on the Angular bootstrap page:
https://ng-bootstrap.github.io/#/getting-started

Element source
ng-bootstrap

Issue description
Ensure all skip links have a focusable target

Note: this issue occurs within HTML_CodeSniffer as well and it is one of the main reasons our team moved away from CodeSniffer and started using aXe.

@WilcoFiers
Copy link
Contributor

Fair point. Thanks for reporting!

@WilcoFiers WilcoFiers added this to the Q2 2018 update milestone Apr 11, 2018
@englishextra
Copy link

englishextra commented Apr 22, 2018

@WilcoFiers And...?

How am I gonna deal with that?

It's not only Angular - it's a hashrouting thing.
having a href = #/home can aXe be able to recognize that as routing stuff and not bookmark of existing block in the markup?

It's not only hashbang - it can be hashslash.

Thanks

@WilcoFiers
Copy link
Contributor

@englishextra Both have been addressed. We're finishing up a few more things for a new release. Should be out within the next week or two.

@englishextra
Copy link

@WilcoFiers Very nice thanks

@ackleyk
Copy link
Author

ackleyk commented Apr 23, 2018

Thank you for fixing this issue so quickly!

mrtnvh pushed a commit to mrtnvh/axe-core that referenced this issue Nov 24, 2023
CI: Remove schedule from auto-patch-release.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants