Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ignore hashbang URLs for skiplinks #827

Merged
merged 1 commit into from
Apr 11, 2018
Merged

fix: Ignore hashbang URLs for skiplinks #827

merged 1 commit into from
Apr 11, 2018

Conversation

WilcoFiers
Copy link
Contributor

Closes #824

@marcysutton
Copy link
Contributor

Looks like there are some failing tests we'll need to resolve.

marcysutton
marcysutton reviewed Apr 4, 2018
View reviewed changes
test/checks/navigation/internal-link-present.js
@@ -9,7 +9,7 @@ describe('internal-link-present', function () {

afterEach(function () {
fixture.innerHTML = '';
axe._tree = undefined;
axe._tree = undefined;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sidenote: should we move this axe._tree thing to the checkContext.reset() method?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're better off not storing the flat tree as a global.

marcysutton
marcysutton reviewed Apr 4, 2018
View reviewed changes
test/checks/navigation/internal-link-present.js
});

it('should return false when a hash route URL was used', function () {
var params = checkSetup('<div id="target"><a href="#/home">hi</a></div>');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see one more test case to mimic OP's issue: href="#!/contact-us"

@WilcoFiers WilcoFiers force-pushed the hashbang-skiplink branch 2 times, most recently from 2cc3e02 to 1dc0d64 Compare April 10, 2018 11:40
@WilcoFiers WilcoFiers merged commit e1f0c57 into develop Apr 11, 2018
@WilcoFiers WilcoFiers deleted the hashbang-skiplink branch April 11, 2018 16:45
@dependencies dependencies bot mentioned this pull request Apr 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcysutton marcysutton marcysutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WilcoFiers @marcysutton