fix: exclude noscript and template from dom.isVisible #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
approved these changes
Nov 22, 2018
| @@ -58,6 +58,8 @@ dom.isVisible = function(el, screenReader, recursed) { | |||
| style.getPropertyValue('display') === 'none' || | |||
| nodeName.toUpperCase() === 'STYLE' || | |||
| nodeName.toUpperCase() === 'SCRIPT' || | |||
| nodeName.toUpperCase() === 'NOSCRIPT' || | |||
| nodeName.toUpperCase() === 'TEMPLATE' || | |||
There was a problem hiding this comment.
I'd suggest an array.includes solution instead of adding even more "or" cases.
WilcoFiers
requested changes
Nov 22, 2018
|
Issue not reproducible, so closing the irrelevant PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR does the below:
NOSCRIPTandTEMPLATEwhen computingisVisible.Closes issue: #864
Reviewer checks
Required fields, to be filled out by PR reviewer(s)