chore: exec lint as separate CI step #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WilcoFiers - we need to enable |
dylanb
reviewed
Nov 22, 2018
| @@ -61,6 +69,10 @@ workflows: | |||
| build: | |||
| jobs: | |||
| - dependencies | |||
| # Run linting | |||
| - lint: | |||
| requires: | |||
There was a problem hiding this comment.
Shouldn't this go into the job definition for lint above?
There was a problem hiding this comment.
I don't think so. Requires is part of the workflow:
https://circleci.com/docs/2.0/configuration-reference/#requires
WilcoFiers
approved these changes
Nov 22, 2018
stephenmathieson
added a commit
that referenced
this pull request
Jan 30, 2019
This patch removes all of the ESLint stuff from the Grunt configuration. There have been numerous efforts to "fix" the existing Grunt/ESLint setup which all seem unnecessary. Now, if you want to lint your code, just do `npm run eslint`. If you don't want to lint your code, then don't do `npm run eslint`. Ref: #1342, #1314, #1267, #1255, #1247, and probably others...
4 tasks
WilcoFiers
pushed a commit
that referenced
this pull request
Feb 1, 2019
This patch removes all of the ESLint stuff from the Grunt configuration. There have been numerous efforts to "fix" the existing Grunt/ESLint setup which all seem unnecessary. Now, if you want to lint your code, just do `npm run eslint`. If you don't want to lint your code, then don't do `npm run eslint`. Ref: #1342, #1314, #1267, #1255, #1247, and probably others... ## Reviewer checks **Required fields, to be filled out by PR reviewer(s)** - [x] Follows the commit message policy, appropriate for next version - [x] Has documentation updated, a DU ticket, or requires no documentation change - [x] Includes new tests, or was unnecessary - [x] Code is reviewed for security by: @WilcoFiers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execute
lintas a separate step in CI.Closes issue: #1252
Reviewer checks
Required fields, to be filled out by PR reviewer(s)