Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rule): Label and Name from Content mismatch WCAG21 (Issue #1149) #1335
feat(rule): Label and Name from Content mismatch WCAG21 (Issue #1149) #1335
Changes from 1 commit
8c80f14
82e5c74
9d2451e
305c864
8501f34
dec7220
abb0673
4de5489
a98448b
e264958
1aded4a
6e67b52
2a5020e
6ff002b
4c6c351
6917ec9
73ded40
2244ed2
6c35b51
9bddd36
3f9a969
1227102
dfa1bd7
d0f45e7
c3a1bdc
ef1c638
14b09b6
7412de8
d615dbe
ad9aa2d
ec2af57
b21e631
3945006
2b07290
6696c5d
9afed3f
b18226f
866fe88
5fefd54
56e4680
fd003e7
072711d
eabb7dd
92489be
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need this if statement. It does nothing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename this file and its tests to
replace-punctuation.js
so that its consistent with the function.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say this needs to be called
hasNonBmpUnicode
, seeing as you're checking if the string includes any such characters, rather than that it only contains those chars. Same for the other functions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason you put the punctuation stuff in a different file, but the emoji stuff in a shared file with nonBmp? Probably best to split those out too.