fix(raw-reporter): do not output DqElements
#1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates our "raw" reporter, ensuring it does not pass `DqElement`s to its callback. Instead, it serializes the `DqElement` by using the `DqElement#toJSON()` method. Unfortunately many of our tests pass non-results to the reporters, so several "guards" were added to the reporter ensuring we don't error while attempting to transform the provided results. In an ideal world, these tests would be rewritten to pass "proper" result objects to our reporters, but this felt out-of-scope for the task at hand. Closes #1195
WilcoFiers
previously requested changes
Apr 25, 2019
It was "dirty" and I just did |
|
Yup, the rule is, |
|
Which is why I thought perhaps And I wanted to roll it back as per this PR #1511 (but there were concerns). |
|
@stephenmathieson Jup, just roll it back. |
|
OK, I'll roll it back. What's the purpose of versioning the file if it's not supposed to be updated tho? |
WilcoFiers
approved these changes
Apr 26, 2019
stephenmathieson
added a commit
to mohanraj-r/axe-core
that referenced
this pull request
May 10, 2019
* develop: (50 commits) docs: add jsdom example and tests (dequelabs#1530) fix(aria-valid-attr-value): allow aria-owns to pass when element is not in the DOM (dequelabs#1526) fix(isSkipLink): cache first page link (dequelabs#1525) chore: update Babel dependencies (dequelabs#1527) chore(package): Update karma to version 4.1.0 (dequelabs#1528) feat: Improve perf of axe.run [WWD-1821] (dequelabs#1503) fix(prettier): ignore generated api doc files (dequelabs#1522) fix(skip-link,region): Allow multiple skiplinks at page top (dequelabs#1496) fix(raw-reporter): do not output `DqElement`s (dequelabs#1513) fix: Scroll state had top and left properties flipped (dequelabs#1469) refactor: commons.color.getBackgroundColor method (dequelabs#1451) fix(aria-valid-attr-value): allow aria-controls to pass when element is not in the DOM chore: Update husky to the latest version 🚀 (dequelabs#1514) style: format HTML files with Prettier (dequelabs#1508) test: Fix invalid test html (dequelabs#1502) feat(rule): Inline text spacing must be adjustable with custom stylesheets (dequelabs#1446) chore: Remove version number from axe.d.ts (dequelabs#1499) chore: Update make-dir to the latest version 🚀 (dequelabs#1465) fix: Exclude iframe for html-has-lang rule (Issue 1424) (dequelabs#1430) feat(utils): add support for complex CSS selectors (dequelabs#1494) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates our "raw" reporter, ensuring it does not pass
DqElements to its callback. Instead, it serializes theDqElementby using theDqElement#toJSON()method.Unfortunately many of our tests pass non-results to the reporters, so several "guards" were added to the reporter ensuring we don't error while attempting to transform the provided results. In an ideal world, these tests would be rewritten to pass "proper" result objects to our reporters, but this felt out-of-scope for the task at hand.
Closes #1195
Reviewer checks
Required fields, to be filled out by PR reviewer(s)