Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run prettier and format #1568

Merged
merged 3 commits into from
May 15, 2019
Merged

chore: run prettier and format #1568

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7db1bb6
chore: run prettier
jeeyyy May 15, 2019
7a296b1
update prettier and re-run fmt
jeeyyy May 15, 2019
f5959ac
merge from develop
jeeyyy May 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions doc/API.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,8 +491,8 @@ preload: { assets: ['cssom'], timeout: 50000 }

The `assets` attribute expects an array of preload(able) constraints to be fetched. The current set of values supported for `assets` is listed in the following table:

| Asset Type | Description |
| :--------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
| Asset Type | Description |
| :--------- | :------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ |
| `cssom` | This asset type preloads all CSS Stylesheets rulesets specified in the page. The stylesheets can be an external cross-domain resource, a relative stylesheet or an inline style with in the head tag of the document. If the stylesheet is an external cross-domain a network request is made. An object representing the CSS Rules from each stylesheet is made available to the checks evaluate function as `preloadedAssets` at run-time |

The `timeout` attribute in the object configuration is `optional` and has a fallback default value (10000ms). The `timeout` is essential for any network dependent assets that are preloaded, where-in if a given request takes longer than the specified/ default value, the operation is aborted.
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@
"minami": "^1.2.3",
"mkdirp": "^0.5.1",
"mocha": "^6.1.2",
"prettier": "^1.17.0",
"prettier": "^1.17.1",
"retire": "^2.0.1",
"revalidator": "~0.3.1",
"selenium-webdriver": "~3.6.0",
Expand Down
69 changes: 40 additions & 29 deletions test/integration/rules/scrollable-region-focusable/scrollable-region-focusable.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,59 +1,70 @@
<!-- pass -->
<div id="pass1" style="overflow: hidden; height: 5px;">
<input type="text">
<input type="text" />
</div>

<div id="pass2" style="height: 200px; overflow: hidden" tabindex="0">
<div style="height: 2000px">
<p> Content </p>
</div>
<div style="height: 2000px">
<p>Content</p>
</div>
</div>

<div id="pass3" style="height: 20px; overflow: auto;">
<input type="text" tabindex="-1">
<select tabindex="-1"></select>
<textarea tabindex="-1"></textarea>
<p style="height: 200px;" tabindex="0"></p>
<input type="text" tabindex="-1" />
<select tabindex="-1"></select>
<textarea tabindex="-1"></textarea>
<p style="height: 200px;" tabindex="0"></p>
</div>


<!-- fail -->
<div id="fail1" style="height: 200px; width: 200px; overflow: hidden">
<div style="height: 2000px; width: 100px;">
<p> Content </p>
</div>
<div style="height: 2000px; width: 100px;">
<p>Content</p>
</div>
</div>

<div id="fail2" style="height: 5px; overflow: auto;">
<input type="text" tabindex="-1">
<input type="text" tabindex="-1" />
</div>

<div id="fail3" style="height: 5px; overflow: auto;">
<input type="text" tabindex="-1">
<select tabindex="-1"></select>
<textarea tabindex="-1"></textarea>
<input type="text" tabindex="-1" />
<select tabindex="-1"></select>
<textarea tabindex="-1"></textarea>
</div>

<!-- inapplicable -->
<section id="inapplicable1">This element is not scrollable</section>

<div id="inapplicable2" style="height: 200px; width: 200px; overflow: auto;">
<div style="height: 10px; width: 100x;">Content</div>
<div style="height: 10px; width: 100x;">Content</div>
</div>

<p id="inapplicable3" style="width: 12em; height: 2em; border: dotted; overflow: visible;">
Sed ut perspiciatis unde
omnis iste natus error sit voluptatem accusantium doloremque laudantium.
<p
id="inapplicable3"
style="width: 12em; height: 2em; border: dotted; overflow: visible;"
>
Sed ut perspiciatis unde omnis iste natus error sit voluptatem accusantium
doloremque laudantium.
</p>

<div id="inapplicable4" style="display: none; height: 200px; overflow: hidden" tabindex="0">
<div style="height: 2000px">
<p> Content </p>
</div>
<div
id="inapplicable4"
style="display: none; height: 200px; overflow: hidden"
tabindex="0"
>
<div style="height: 2000px">
<p>Content</p>
</div>
</div>

<div id="inapplicable5" aria-hidden="true" style="height: 200px; overflow: hidden" tabindex="0">
<div style="height: 2000px">
<p> Content </p>
</div>
</div>
<div
id="inapplicable5"
aria-hidden="true"
style="height: 200px; overflow: hidden"
tabindex="0"
>
<div style="height: 2000px">
<p>Content</p>
</div>
</div>