feat(core): add preload configuration option for media files #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeeyyy
changed the title
WilcoFiers
previously requested changes
Jan 8, 2020
WilcoFiers
previously approved these changes
Jan 10, 2020
lib/core/utils/preload-media.js
Outdated
| treeRoot, | ||
| 'video, audio' | ||
| ); | ||
| if (!mediaVirtualNodes || !mediaVirtualNodes.length) { |
There was a problem hiding this comment.
this is statement can be removed. mediaVirtualNodes is will always be an array, and an empty array will work fine with your map function. Promise.all will resolve.
WilcoFiers
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional type 'media' to the
preloadconfiguration.The intention of this configuration is to await running some rules which requires some metadata from HTMLMediaElement to run checks.
An example of one such rule would be no-autoplay-audio, which relies on duration property of a media file.
Closes issue:
Reviewer checks
Required fields, to be filled out by PR reviewer(s)