chore: convert to esbuild #2579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one @straker |
| bundle: true | ||
| }) | ||
| .then(done) | ||
| .catch(done); |
There was a problem hiding this comment.
Should be calling done(false) here according to the Grunt docs
There was a problem hiding this comment.
Either false or an Error object may be passed to the done function to instruct Grunt that the task has failed.
I checked and esbuild gives an error in the catch and a success object in the then.
WilcoFiers
approved these changes
Oct 22, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Esbuild is a "newer" javascript bundler that I've been interested in trying out. It runs super fast (benchmarks on their repo) and looking at the output does Rollup style resolving where it concats the functions by use instead of using webpack style resolve (resulting in cleaner and smaller output). Even better, esbuild works out of the box to resolve node_module style webpack paths and doesn't have the same problem I was facing with Rollup and having to add a few plugins for that (and still ran into issues with Axios).
Doing this resulted in a filesize decrease of 15 kB gzipped.
Webpack stats:
Esbuild stats
Part of issue: #2357
Reviewer checks
Required fields, to be filled out by PR reviewer(s)