Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace phrasing elements in subtree-text #2665

Merged
merged 2 commits into from
Nov 30, 2020
Merged

chore: replace phrasing elements in subtree-text #2665

merged 2 commits into from
Nov 30, 2020

Conversation

straker
Copy link
Contributor

@straker straker commented Nov 25, 2020

Had to make input not a phrasing element in order to pass the accessible name acceptance tests. Also, should we add #text as an html element so we don't have to concat it to the end of the array?

Closes issue: #2632

Reviewer checks

Required fields, to be filled out by PR reviewer(s)

  • Follows the commit message policy, appropriate for next version
  • Code is reviewed for security

@straker straker requested a review from a team as a code owner November 25, 2020 21:14
@straker straker merged commit 6aab97f into develop Nov 30, 2020
@straker straker deleted the phrasing branch November 30, 2020 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants