feat(frame-focusable-content): new rule to test iframes with tabindex=-1 do not have focusable content #2785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…=-1 do not have focusable content
|
For whatever reason the thing that cases frame-test rule to fail is adding a nested iframe to this rules integration test. It doesn't matter if the |
straker
commented
Jan 29, 2021
| let width = parseInt(frame.node.getAttribute('width'), 10); | ||
| let height = parseInt(frame.node.getAttribute('height'), 10); | ||
| width = isNaN(width) ? rect.width : width; | ||
| height = isNaN(height) ? rect.height : height; |
There was a problem hiding this comment.
This prevents margin/border/padding CSS from affecting the width/height (otherwise in Chrome a width and height of 1 would result in a rect size of 5x5).
WilcoFiers
approved these changes
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling out more of #2762 to see if it fixes the ie11 problem that only happens in circle.
Note: The
aftermethod is incomplete on purpose. This is just the minimalistic amount of code necessary in order to get the rule to run.