fix(utils): remove attributes from source string #2803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
reviewed
Feb 15, 2021
straker
changed the title
WilcoFiers
previously requested changes
Feb 16, 2021
|
Went with using the node itself to apply css selector matching. |
WilcoFiers
previously requested changes
Feb 26, 2021
| node.appendChild(filterHtmlAttrs(child, filterAttrs)); | ||
| }); | ||
|
|
||
| return node; |
There was a problem hiding this comment.
Why is this returning elements? Isn't doing a bit of string manipulation much faster than creating entirely new DOM structures?
There was a problem hiding this comment.
If we're matching CSS selectors we cannot work on just strings. I wanted to remove attributes but IE11 wouldn't remove value from an input element so had to instead recreate the DOM from scratch. Since the elements are not part of the DOM they shouldn't incur any performance penalties by reflow or repaints.
WilcoFiers
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unwanted attributes from source string. Will add all the audit code around it in another pr so this one doesn't get too big.
For the record; this does add a small feature, but it is a feature necessary to address a security fix that will need to be applied to all supported minor versions of axe-core. We are therefor tagging this as a "fix" instead of a "feat".