Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(empty-table-header): new rule to flag empty table headers #2811

Merged
merged 8 commits into from
Feb 26, 2021
Merged

feat(empty-table-header): new rule to flag empty table headers #2811

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
bb7c671
Add initial version of aria-table-header-name rule
jlin95 Feb 14, 2021
7fd95fd
Add tests for aria-empty-table-header rule
jlin95 Feb 17, 2021
d40c697
Fix PR comments
jlin95 Feb 22, 2021
aae3139
rename rule, fix tests
jlin95 Feb 23, 2021
51f75bf
Rename rule
jlin95 Feb 23, 2021
dd8c804
Update test file and main rule naming
jlin95 Feb 23, 2021
d19ab27
Remove extra aria-empty-header-name rule
jlin95 Feb 23, 2021
ff43db1
Update PR for test
jlin95 Feb 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions doc/rule-descriptions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,11 @@

## WCAG 2.1 Level A & AA Rules

| Rule ID | Description | Impact | Tags | Issue Type |
| :----------------------------------------------------------------------------------------------------------------- | :-------------------------------------------------------------------------------------------- | :------ | :-------------------------------- | :--------- |
| [autocomplete-valid](https://dequeuniversity.com/rules/axe/4.1/autocomplete-valid?application=RuleDescription) | Ensure the autocomplete attribute is correct and suitable for the form field | Serious | cat.forms, wcag21aa, wcag135 | failure |
| [avoid-inline-spacing](https://dequeuniversity.com/rules/axe/4.1/avoid-inline-spacing?application=RuleDescription) | Ensure that text spacing set through style attributes can be adjusted with custom stylesheets | Serious | cat.structure, wcag21aa, wcag1412 | failure |
| Rule ID | Description | Impact | Tags | Issue Type |
| :----------------------------------------------------------------------------------------------------------------- | :-------------------------------------------------------------------------------------------- | :------ | :-------------------------------- | :------------------------- |
| [empty-table-header](https://dequeuniversity.com/rules/axe/4.1/empty-table-header?application=RuleDescription) | Ensures table headers have discernible text | Minor | wcag131, cat.aria | failure, needs review |
| [autocomplete-valid](https://dequeuniversity.com/rules/axe/4.1/autocomplete-valid?application=RuleDescription) | Ensure the autocomplete attribute is correct and suitable for the form field | Serious | cat.forms, wcag21aa, wcag135 | failure |
| [avoid-inline-spacing](https://dequeuniversity.com/rules/axe/4.1/avoid-inline-spacing?application=RuleDescription) | Ensure that text spacing set through style attributes can be adjusted with custom stylesheets | Serious | cat.structure, wcag21aa, wcag1412 | failure |

## Best Practices Rules

Expand Down
13 changes: 13 additions & 0 deletions lib/rules/empty-table-header.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"id": "empty-table-header",
"selector": "th, [role=\"rowheader\"], [role=\"columnheader\"]",
"tags": ["wcag131", "cat.aria"],
"reviewOnFail": true,
"metadata": {
"description": "Ensures table headers have discernible text",
"help": "Table header text must not be empty"
},
"all": [],
"any": ["has-visible-text"],
"none": []
}
49 changes: 49 additions & 0 deletions test/integration/rules/empty-table-header/empty-table-header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
<html lang="en">
<head>
<title>empty-table-header test</title>
<meta charset="utf8" />
<script src="/axe.js"></script>
</head>

<body>
<table>
<tr>
<th id="pass1">Ok</th>
</tr>
</table>

<table>
<tr>
<td id="pass2" role="rowheader">rowheader with name</td>
</tr>
</table>

<table>
<tr>
<td id="pass3" role="columnheader">columnheader with name</td>
</tr>
</table>

<table>
<tr>
<th id="incomplete1"></th>
</tr>
</table>

<table>
<tr>
<td id="incomplete2" role="rowheader">
<div style="display: none">Not Ok</div>
</td>
</tr>
</table>

<table>
<tr>
<td id="incomplete3" role="columnheader">
<div style="display: none">Not Ok</div>
</td>
</tr>
</table>
</body>
</html>
6 changes: 6 additions & 0 deletions test/integration/rules/empty-table-header/empty-table-header.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"description": "empty-table-header tests",
"rule": "empty-table-header",
"incomplete": [["incomplete1"], ["incomplete2"], ["incomplete3"]],
jlin95 marked this conversation as resolved.
Show resolved Hide resolved
"passes": [["#pass1"], ["#pass2"], ["#pass3"]]
}