-
Notifications
You must be signed in to change notification settings - Fork 788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: deprecate autocomplete appropriate check #2917
feat: deprecate autocomplete appropriate check #2917
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I talked to Wilco and he mentioned that we should also remove the check from the rule metadata as well. Sorry about that.
@straker I'm not sure what you mean by that, would you mind being more specific? I did notice looking at some other deprecated checks that the impact for the others was 'minor' - it makes sense to me that a deprecated check shouldn't be a severe impact, so I made that change. Can reverse it if that was the wrong call. |
Ah I think I figured it out! :D |
Sorry missed the first question. Yes you removed it correctly. As for the impact change I don't think we should do that as the impact is based on user testing. The tests will also need to be updated with the removal of the check as those failures will no longer fail. |
Reviewed for security. |
Deprecates autocomplete-appropriate
Closes issue: #2912