fix(allowed-role): area without href can have a button or link role #3275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilcoFiers
commented
Nov 12, 2021
| @@ -223,12 +223,4 @@ describe('aria.isAriaRoleAllowedOnElement', function() { | |||
| var actual = axe.commons.aria.isAriaRoleAllowedOnElement(node, 'link'); | |||
| assert.isTrue(actual); | |||
| }); | |||
|
|
|||
| it('returns false if elements implicit role does not match the role', function() { | |||
There was a problem hiding this comment.
I don't think this test adds any value. It doesn't return false for just this reason, it returns false because none of the things we test for that could make it true are. So I decided to remove it rather than put in some other element.
straker
approved these changes
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per a recent update in ARIA in HTML
Closes issue: #3266