Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aria-allowed-role): add meter to allowed roles for named img #4055

Merged
merged 5 commits into from
Jun 16, 2023

Conversation

scottaohara
Copy link
Contributor

closes #4054

as stated in the PR title, this adds the meter element to be an allowed role for the img element when it is provided an accessible name.

@scottaohara scottaohara requested a review from a team as a code owner June 15, 2023 15:49
Copy link
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr. Would you be able to add a test for this is test/integration/aria-allowed-role.html. Just adding an image tag with the new role and an id that will need to be added to the companion json file pass section.

@straker straker changed the title Update: add meter to allowed roles for named img fix(aria-allowed-role): add meter to allowed roles for named img Jun 15, 2023
@scottaohara
Copy link
Contributor Author

added

@straker
Copy link
Contributor

straker commented Jun 15, 2023

Thanks. The element will need an id attribute and then the id will need to be added to the companion aria-allowed-role.json file to the passes section (that should resolve the tests).

Copy link
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for doing that.

Reviewed for security.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update allowed roles (meter) for img element
2 participants