Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set relatedNodes on color/link-in-block rules #407

Merged
merged 1 commit into from
Jul 7, 2017

Conversation

WilcoFiers
Copy link
Contributor

No description provided.

@WilcoFiers WilcoFiers requested a review from marcysutton July 6, 2017 11:17
Copy link
Contributor

@marcysutton marcysutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned in the extension review, some incomplete results are still falling through with "Unable to determine contrast ratio" and no relatedNodes. But we can address that separately.

@WilcoFiers WilcoFiers merged commit 7fde0fe into develop Jul 7, 2017
@marcysutton marcysutton deleted the fix/incomplete-related-nodes branch July 7, 2017 17:16
WilcoFiers added a commit that referenced this pull request Jul 13, 2017
* fix implicit attribute us in duplicate-id

* fix: Only access node id's through getAttribute

* Minor build chores for whitespace and lockfile (#366)

* chore: convert spaces to tabs in Gruntfile

Align the file with the EditorConfig setting

* chore: ignore package-lock.json

This file is produced by NPM 5, but this repo didn't use the old
shrinkwrap version so this should be excluded

* fix: Set relatedNodes on color/link-in-block rules (#407)

* chore: ignore growl in retire

* Add instructions on debugging on CircleCI

* chore: Fix spacing issues

* fix implicit attribute us in duplicate-id

* fix: Only access node id's through getAttribute

* chore: Fix spacing issues

* fix: JSHint issue
mrtnvh pushed a commit to mrtnvh/axe-core that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants