-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aria-prohibited-attr): add support fallback role #4325
base: develop
Are you sure you want to change the base?
Conversation
Thanks for the pr. Unfortunately with axe-con quickly approaching we won't be able to look at this any time soon. After axe-con we'll be able to revisit this again. |
Thank you for providing the information. I wish you a successful event, as in previous years. Please let me know if you need any changes are necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Just a couple small suggestions. @takenspc thank you for putting this together!
Would you mind adding one or two test cases to test/integration/rules/aria-prohibited-attr/aria-prohibited-attr.html
and its .json
file as well?
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Thank you for your review.
I have added a few tests to Although I need to update this branch to pass CI tests, it may be better to wait until #4354 is merged. |
This PR adds fallback role support to
aria-prohibited-attr
. For example,<div role="foo img" aria-label="...">
is legal.At this time, I do not plan to add fallback roles support for other checks.
Related:
Closes: