Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attempt to fix ci build failures. #917

Merged
merged 2 commits into from
May 28, 2018
Merged

fix: attempt to fix ci build failures. #917

merged 2 commits into from
May 28, 2018

Conversation

jeeyyy
Copy link
Contributor

@jeeyyy jeeyyy commented May 25, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

Description of the changes

  • Tackled the issue of CircleCI kicking the bucket intermittently due to timeout error on script execution for mobile web-driver (chrome-mobile).
  • Github issue: Fix flakiness of integration tests on Circle CI #805
  • Although this looked like grunt concurrency, or non-availability of gecko-driver, or docker base image issue, this was purely a configuration for web-driver.
  • Also over-rid node ENV to not default to Http2, to avoid experimental warning on the terminal.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@WilcoFiers
Copy link
Contributor

Lets run this a bunch of time to see if it solved the problem.

@jeeyyy jeeyyy changed the title fix: attempt to fix ci build failures. (WIP) fix: attempt to fix ci build failures. May 28, 2018
@jeeyyy jeeyyy changed the title (WIP) fix: attempt to fix ci build failures. fix: attempt to fix ci build failures. May 28, 2018
@jeeyyy
Copy link
Contributor Author

jeeyyy commented May 28, 2018

re-ran build multiple times, succeeds on each run - https://circleci.com/gh/dequelabs/axe-core/tree/build-failure-fix

@jeeyyy jeeyyy merged commit a343771 into develop May 28, 2018
@jeeyyy jeeyyy deleted the build-failure-fix branch May 28, 2018 14:22
@dylanb
Copy link
Contributor

dylanb commented May 28, 2018

@JKODU you have mixed style changes into some fix commits, this goes against our commit guidelines. Can you undo the style changes and put them into a separate commit.

@jeeyyy
Copy link
Contributor Author

jeeyyy commented May 28, 2018

@dylanb sure thing.

@dylanb
Copy link
Contributor

dylanb commented May 29, 2018

@JKODU looks like this got merged already

@jeeyyy
Copy link
Contributor Author

jeeyyy commented May 29, 2018

@dylanb
Yup, we merge before this was raised, to help with reducing the number of re-builds we had to run. Will cater to the requested changes in the next issue I am tackling. In my radar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants