Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to React 17 #1473

Closed
scurker opened this issue May 1, 2024 · 1 comment · Fixed by #1680
Closed

Update to React 17 #1473

scurker opened this issue May 1, 2024 · 1 comment · Fixed by #1680
Assignees
Milestone

Comments

@scurker
Copy link
Member

scurker commented May 1, 2024

Once #1159 is complete, we should upgrade as a half-step to React 17. This should include both react and react-dom for development dependencies in the following packages:

  • ./ (root)
  • packages/react

No changes needed for peerDependencies until React 18 (see #631)

Also see https://legacy.reactjs.org/blog/2020/08/10/react-v17-rc.html for a reference of changes that may be needed. Running the newly updated tests should be sufficient to see if any specific issues are caught as the result of the upgrade.

@scurker
Copy link
Member Author

scurker commented Jul 10, 2024

I've performed a functional assessment of each component to determine their compatibility with React 17. This is by no means comprehensive, but is testing the expected behavior of each component and if there are any regressive behaviors with React 17:

  • ✅ Accordion
  • ✅ Address
  • ✅ Alert
  • ✅ Breadcrumb
  • ✅ Button
  • ✅ Checkbox
  • ✅ ClickOutsideListener
  • ✅ Code
  • ✅ Combobox
  • ✅ DescriptionList
  • ✅ ExpandCollapsePanel
  • ✅ FieldWrap
  • ✅ Icon
  • ✅ IconButton
  • ✅ Layout
  • ✅ Line
  • ✅ Link
  • ✅ Listbox
  • ✅ Loader
  • ✅ LoaderOverlay
  • ❌ Modal (confirmed issue, see Bug: Modal broken in React 17+ #1087)
  • ✅ NavBar
  • ✅ Notice
  • ✅ Offscreen
  • ❌ OptionsMenu (confirmed issue, see Bug: OptionsMenu broken in React 17+ #830)
  • ✅ Pagination
  • ✅ Panel
  • ❌ Popover (confirmed issue, likely related to either Bug: Modal broken in React 17+ #1087 and Bug: OptionsMenu broken in React 17+ #830)
  • ✅ ProgressBar
  • ✅ RadioCardGroup
  • ✅ Scrim
  • ✅ SearchField
  • ✅ Select
  • ✅ SkipLink
  • ✅ Stepper
  • ✅ Table
  • ✅ Tabs
  • ✅ Tag
  • ✅ TagButton
  • ✅ TextEllipsis
  • ✅ TextField
  • ✅ Timeline
  • ✅ Toast
  • ✅ Tooltip
  • ✅ TooltipTabstop
  • ✅ TopBar
  • ✅ TwoColumnPanel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants