-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react): support react 17 #1680
Conversation
ff1b1e5
to
84b23af
Compare
This pull request is automatically being deployed by Amplify Hosting (learn more). |
f6fe383
to
ab1f0c2
Compare
469811e
to
9b75a9c
Compare
991f913
to
aaa242c
Compare
fcb43d8
to
cda2956
Compare
6e50a3a
to
ede47b8
Compare
ad1a367
to
250db1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks pretty good, but I do think we need to address the breaking change here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM!
I did a check with everything in the deploy preview and it looks like we've resolved all of the issues! There does appear to be 2 tests failing which we need to determine why they're failing before this can be merged, but otherwise great work!
I updated the onClose test that failed. The new code in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎈 🎉 🎆
closes #1473
closes #1574
closes #1087
closes #830
This PR does a few things:
OptionsMenu
andPopover
component, when a user opens them, clicking on the trigger buttons will now close them instead of triggering the click outsideclose()
methodOptionsMenu
components to function componentsTopBar
docs so that theOptionsMenu
now has a trigger to referenceVerification Steps
OptionsMenu
componentOptionsMenu
OptionsMenu
will close theOptionsMenu
Popover
componentPopover
Popover
will close thePopover
TopBar
with menu componentOptionsMenu
inside theTopBar
OptionsMenu
will close theOptionsMenu