-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react): remove PropTypes from all react components #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview branch generated at https://remove-prop-types.d1gko6en628vir.amplifyapp.com |
99% of the output here was done via the following codemod and jscodeshift commands: Codemodimport type {
API,
FileInfo
} from 'jscodeshift'
export default function (file: FileInfo, api: API) {
const j = api.jscodeshift;
const root = j(file.source);
// Find assignment propTypes and remove them
const assignmentPropTypes = root
.find(j.AssignmentExpression, {
left: {
property: {
name: 'propTypes'
}
}
})
assignmentPropTypes.remove();
// Find static propTypes from class based components and remove them
const staticPropTypes = root
.find(j.ClassProperty, {
key: {
type: 'Identifier',
name: 'propTypes'
},
static: true
})
staticPropTypes.remove()
// Remove import declaration
const importPropType = root
.find(j.ImportDeclaration, {
source: {
value: 'prop-types'
}
})
importPropType.remove()
return root.toSource();
} CLI Commandnpx jscodeshift -t ./remove-react-prop-types.ts --parser=tsx --extensions=tsx ./packages/react/src/**/*.tsx |
thuey
reviewed
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of places where className
was added, but it seems unnecessary, unless I'm missing something.
thuey
approved these changes
Oct 19, 2023
thuey
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This removes all PropTypes from react components. If an author needs to depend on specific types, the recommendation going forward is to use Typescript types to validate React component props.
closes #1164