Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(styles): fix layout issues with dialog header when wrapping #1253

Merged
merged 1 commit into from
Oct 20, 2023
Merged

fix(styles): fix layout issues with dialog header when wrapping #1253

merged 1 commit into from
Oct 20, 2023

Conversation

scurker
Copy link
Member

@scurker scurker commented Oct 20, 2023

I noticed that the dialog header had some issues when text was wrapping, this adjust the spacing to correctly wrap long dialog titles.

Before

dialog header with incorrect spacing and sizing of close button too small

After

dialog header with correct spacing and wrapping between title and button

@scurker scurker requested a review from a team as a code owner October 20, 2023 14:54
@scurker scurker requested a review from a team October 20, 2023 14:54
@github-actions
Copy link
Contributor

Preview branch generated at https://fix-dialog-styles.d1gko6en628vir.amplifyapp.com

@scurker scurker merged commit 565d26c into develop Oct 20, 2023
@scurker scurker deleted the fix-dialog-styles branch October 20, 2023 15:18
@github-actions
Copy link
Contributor

Preview branch generated at https://fix-dialog-styles.d1gko6en628vir.amplifyapp.com

@github-actions github-actions bot mentioned this pull request Oct 20, 2023
Merged
@scurker scurker mentioned this pull request Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thuey thuey thuey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scurker @thuey