Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow customization of log indicators with skin theme #2024

Closed
mikesmithgh opened this issue Mar 21, 2023 · 2 comments
Closed

feat: allow customization of log indicators with skin theme #2024

mikesmithgh opened this issue Mar 21, 2023 · 2 comments

Comments

@mikesmithgh
Copy link
Contributor




Is your feature request related to a problem? Please describe.
Add fields to logs.indicator section of skin yaml to customize indicator colors (e.g., autoscroll, fullscreen, timestamps, wrap, etc)

Describe the solution you'd like
Add options to LogIndicator section of skin.
E.g.,

    logs:
      fgColor: *lightskyblue
      bgColor: *black
      indicator:
        fgColor: *dodgerblue
        bgColor: *black

Additional context
Source is currently hardcoding limegreen and gray https://github.com/derailed/k9s/blob/master/internal/view/log_indicator.go#L129
Screenshot 2023-03-21 at 3 53 02 PM

I may give this one a shot 🤷 but don't hold me to it 😂

@slimus
Copy link
Collaborator

slimus commented Apr 3, 2023

@mikesmithgh do you want to publish PR for it?

@mikesmithgh
Copy link
Contributor Author

@mikesmithgh do you want to publish PR for it?

Hi @slimus, thanks for the nudge 🙂. I opened a PR for this issue: #2041

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants