Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tty: true to the node shell pod manifest #2219

Closed
sprat opened this issue Sep 13, 2023 · 1 comment
Closed

Add tty: true to the node shell pod manifest #2219

sprat opened this issue Sep 13, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@sprat
Copy link

sprat commented Sep 13, 2023

Is your feature request related to a problem? Please describe.

I would like to use a nsenter image (e.g. alexeiled/nsenter) in the node shelll pod in order to enter all the namespaces of PID 1 (as if I logged in directly on the node), but the nsenter tools requires a TTY to be opened.

Describe the solution you'd like

add tty: true to the node shell pod manifest generated by k9s (all the other requirements are already there, i.e. stdin: true, privileged: true, hostNetwork: true and hostPID: true)

Describe alternatives you've considered
For now, I have a separate script to create the nsenter pod

Additional context
@derailed derailed added enhancement New feature or request InProgress labels Nov 21, 2023
derailed added a commit that referenced this issue Dec 7, 2023
@derailed
Fix #2219: Turn on TTY option on shellpod
1b7c31a
@derailed derailed mentioned this issue Dec 7, 2023
Merged
derailed added a commit that referenced this issue Dec 7, 2023
@derailed
K9s Release v0.29.0 (#2326)
a44cb61 
* Feat: Move shell pod cluster config to general config

> BREAKING CHANGE! K9s configuration breaking change! Shellpod specification will
no longer reside with a cluster configuration. It is now part of the
global K9s configuration object.

Shellpod configuration should be part of k9s config. Clusters admins
will most likely use the same image and config to run shells on their
nodes. Each cluster in turn will have the option to either
enable/disable shelling into nodes. This not only DRYs up the k9s config
but also allows user to consolidate their shell pod configuration in one
central place.

* Fix #2290 - Add freebsd assets

* Maintenance cleaning up

* Fix #2166 - Add taint tracking column to node view

* Fix #2009: Update screendump file names to contain resource info

* Maintenance: Cleanup errror messages

* Fix #1513: Change log default to tail vs last 5min

* Fix #2166: Add taint indicator on node view

* Fix #2165: Track init co restarts

* Fix #2308: Fix rbac auth checks

* Fix #2036: Fix npe on filtering CRDs

* Fix #2219: Turn on TTY option on shellpod

* Fix #2167: Update color escape sequence on copy

* Fix #2297: Enable multi select on nodes

* Cleanup headers

* Fix #2162: Allow edit when describing/viewing

* Feat: Add helm release history support

* Fix #2039: Command Arrow up/down + enter support

* Small refactor

* Add img vulenerability scans support

* Change skin loading and support

- Move skin specification to k9s cluster config section
- Load skins for skins dir

* Release v0.29.0 docs
@sprat
Copy link
Author

sprat commented Dec 7, 2023

Thanks!

thejoeejoee pushed a commit to thejoeejoee/k9s that referenced this issue Feb 23, 2024
@derailed @thejoeejoee
K9s Release v0.29.0 (derailed#2326)
490c1ee 
* Feat: Move shell pod cluster config to general config

> BREAKING CHANGE! K9s configuration breaking change! Shellpod specification will
no longer reside with a cluster configuration. It is now part of the
global K9s configuration object.

Shellpod configuration should be part of k9s config. Clusters admins
will most likely use the same image and config to run shells on their
nodes. Each cluster in turn will have the option to either
enable/disable shelling into nodes. This not only DRYs up the k9s config
but also allows user to consolidate their shell pod configuration in one
central place.

* Fix derailed#2290 - Add freebsd assets

* Maintenance cleaning up

* Fix derailed#2166 - Add taint tracking column to node view

* Fix derailed#2009: Update screendump file names to contain resource info

* Maintenance: Cleanup errror messages

* Fix derailed#1513: Change log default to tail vs last 5min

* Fix derailed#2166: Add taint indicator on node view

* Fix derailed#2165: Track init co restarts

* Fix derailed#2308: Fix rbac auth checks

* Fix derailed#2036: Fix npe on filtering CRDs

* Fix derailed#2219: Turn on TTY option on shellpod

* Fix derailed#2167: Update color escape sequence on copy

* Fix derailed#2297: Enable multi select on nodes

* Cleanup headers

* Fix derailed#2162: Allow edit when describing/viewing

* Feat: Add helm release history support

* Fix derailed#2039: Command Arrow up/down + enter support

* Small refactor

* Add img vulenerability scans support

* Change skin loading and support

- Move skin specification to k9s cluster config section
- Load skins for skins dir

* Release v0.29.0 docs
placintaalexandru pushed a commit to placintaalexandru/k9s that referenced this issue Apr 3, 2024
@derailed
K9s Release v0.29.0 (derailed#2326)
d5f443b 
* Feat: Move shell pod cluster config to general config

> BREAKING CHANGE! K9s configuration breaking change! Shellpod specification will
no longer reside with a cluster configuration. It is now part of the
global K9s configuration object.

Shellpod configuration should be part of k9s config. Clusters admins
will most likely use the same image and config to run shells on their
nodes. Each cluster in turn will have the option to either
enable/disable shelling into nodes. This not only DRYs up the k9s config
but also allows user to consolidate their shell pod configuration in one
central place.

* Fix derailed#2290 - Add freebsd assets

* Maintenance cleaning up

* Fix derailed#2166 - Add taint tracking column to node view

* Fix derailed#2009: Update screendump file names to contain resource info

* Maintenance: Cleanup errror messages

* Fix derailed#1513: Change log default to tail vs last 5min

* Fix derailed#2166: Add taint indicator on node view

* Fix derailed#2165: Track init co restarts

* Fix derailed#2308: Fix rbac auth checks

* Fix derailed#2036: Fix npe on filtering CRDs

* Fix derailed#2219: Turn on TTY option on shellpod

* Fix derailed#2167: Update color escape sequence on copy

* Fix derailed#2297: Enable multi select on nodes

* Cleanup headers

* Fix derailed#2162: Allow edit when describing/viewing

* Feat: Add helm release history support

* Fix derailed#2039: Command Arrow up/down + enter support

* Small refactor

* Add img vulenerability scans support

* Change skin loading and support

- Move skin specification to k9s cluster config section
- Load skins for skins dir

* Release v0.29.0 docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@derailed @sprat