Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot add plugins to helm scope #2501

Closed
philipp94831 opened this issue Jan 24, 2024 · 6 comments
Closed

Cannot add plugins to helm scope #2501

philipp94831 opened this issue Jan 24, 2024 · 6 comments
Labels
bug Something isn't working InProgress Marks an issue has being worked on question Further information is requested

Comments

@philipp94831
Copy link




Describe the bug
Before upgrading to v0.31.7, I had a plugin defined for helm scope. After upgrading to v0.31.7, Helm scope does not load the plugin. Plugins for other scopes are working fine.

To Reproduce
Steps to reproduce the behavior:

  1. Add https://github.com/derailed/k9s/blob/master/plugins/helm-default-values.yaml to plugins.yaml
  2. Open :helm scope
  3. Plugin is missing

Expected behavior
Plugin is loaded

Versions (please complete the following information):

  • OS: Windows 11
  • K9s: 0.31.7
  • K8s: 1.25.16-eks
@derailed derailed added the question Further information is requested label Jan 24, 2024
@derailed
Copy link
Owner

@philipp94831 Please double check plugins: vs plugin: and/or check k9s debug logs.

@philipp94831
Copy link
Author

@derailed I did once again. File is called plugins.yaml and I copy-pasted https://github.com/derailed/k9s/blob/master/plugins/helm-default-values.yaml with plugins: as the root key

@derailed
Copy link
Owner

@philipp94831 What does the k9s logs say?

@philipp94831
Copy link
Author

Nothing in the logs wrt plugins. I used -l debug. If I change the scope of the plugin to any other, e.g., po, the shortcut is properly displayed.

@derailed
Copy link
Owner

@philipp94831 Thanks for the details! Found the issue. will fix in the next drop ;(
In the interim please try scopes: [chart]

@derailed derailed added bug Something isn't working InProgress Marks an issue has being worked on labels Jan 24, 2024
@philipp94831
Copy link
Author

chart works like a charm. Thanks!

derailed added a commit that referenced this issue Feb 7, 2024
derailed added a commit that referenced this issue Feb 7, 2024
placintaalexandru pushed a commit to placintaalexandru/k9s that referenced this issue Apr 3, 2024
* [Maint] Fix race condition issue

* [Bug] Fix derailed#2501

* [Maint] Allow reference to resource aliases for plugins

* [Feat] Intro cp namespace command + misc cleanup

* [Maint] Rev k8s v0.29.1

* [Bug] Fix derailed#1033, derailed#1558

* [Bug] Fix derailed#2527

* [Bug] Fix derailed#2520

* rel v0.31.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working InProgress Marks an issue has being worked on question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants