Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the sanitize feature easier to use #2608

Closed
tonsV2 opened this issue Mar 11, 2024 · 3 comments
Closed

Make the sanitize feature easier to use #2608

tonsV2 opened this issue Mar 11, 2024 · 3 comments

Comments

@tonsV2
Copy link

tonsV2 commented Mar 11, 2024

Is your feature request related to a problem? Please describe.

I'd like to use the sanitize feature without typing "sanitize me pods!".

Describe the solution you'd like

A simple check box or the string "yes" would suffice.

Additional context

I'm just wiping completed jobs and restarting some instances, it's not a nuclear launch I'm instantiating.

@derailed
Copy link
Owner

@tonsV2 +1 for humor. Noace!!

@tonsV2
Copy link
Author

tonsV2 commented Mar 18, 2024

Thanks for the response! Thinking a bit more about this, maybe we don't even need to type anything. Wouldn't a simple confirm dialog with ok/cancel buttons do? It's not really a destructive command

derailed added a commit that referenced this issue Mar 20, 2024
derailed added a commit that referenced this issue Mar 20, 2024
* [Bug] fix #2605

* [Bug] fix #2604

* [Bug] fix #2592

* [Bug] fix #2608

* [Bug] Fix #2612

* Rel v0.32.4
@Michael-Baylis
Copy link

@derailed I was also hoping for this to be simplified, but changing "sanitize me pods!" to "Yes Please!" is not much different. Could we just have the same as "Force: X", just put an X in there with the space bar. As @tonsV2 says, it is not really a destructuve command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants