Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #1089

Merged
merged 91 commits into from
Apr 27, 2021
Merged

Spelling #1089

merged 91 commits into from
Apr 27, 2021

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Apr 16, 2021

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@2b01b10#commitcomment-49586199

The action reports that the changes in this PR would make it happy: jsoref@d659b02

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@@ -16,9 +16,9 @@ Also if you dig this tool, please make some noise on social! [@kitesurfer](https

I always seem to get this wrong... Does Labor Day weekend mean you get to work on your OSS projects all weekend?

I am very excited about this drop and hopefully won't be hunamimous on this? 🐭
I am very excited about this drop and hopefully won't be unanimous (?) on this? 🐭
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@derailed: I'm not at all certain about this.

@@ -14,7 +14,7 @@ On Slack? Please join us [K9slackers](https://join.slack.com/t/k9sers/shared_inv

## 🙀(PLUGIN-19)

[BR]eaking bad on K9s plugins! In previous releases, we used the COL<INDEX> semantic to reference view column data in the plugin extensions. In this drop, we've axed this in favor of column name vs column index. This makes K9s plugin more readable and usable. Also, in light of custom columns, this old semantic just did not jive to well. To boot, all columns available on the viewed resource, regardless of display preferences or order are now free game to plugin authors. So for folks currently leveraging K9s plugins, this drop will break you I am hopeful you guys dig this approach betta??
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the show. I guess should have been [Br]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want [Br]eaking [Ba]d -- totally happy to do this.

Amusingly, betta here should really be beta (the former is a genus of 🐟 ).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went with betta' to match a similar instance. Although I'm going to have to consider adding betta to my list of "not words you want to use", since I suspect on average it's a typo of something.

@@ -16,7 +16,7 @@ On Slack? Please join us [K9slackers](https://join.slack.com/t/k9sers/shared_inv

And now for something a `beat` different?

I figured, why not share one of the tunes I was spinning when powering thru teh bugs? Might as well share the pain/pleasure roaght?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're attached to these spellings, I can trivially drop individual commits.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well this is for fun - usually write the release docs late at night so a little liberty is in order...

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Josh - inside humor likely no one gets - so do make it right!

internal/view/helpers_test.go Show resolved Hide resolved
README.md Show resolved Hide resolved
Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR Josh! As for myself, shorter prs make me happy...
...and there I was thinking I was a great speller. Time to re-install the ever so annoying spell checker ;(

@@ -14,7 +14,7 @@ On Slack? Please join us [K9slackers](https://join.slack.com/t/k9sers/shared_inv

## 🙀(PLUGIN-19)

[BR]eaking bad on K9s plugins! In previous releases, we used the COL<INDEX> semantic to reference view column data in the plugin extensions. In this drop, we've axed this in favor of column name vs column index. This makes K9s plugin more readable and usable. Also, in light of custom columns, this old semantic just did not jive to well. To boot, all columns available on the viewed resource, regardless of display preferences or order are now free game to plugin authors. So for folks currently leveraging K9s plugins, this drop will break you I am hopeful you guys dig this approach betta??
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per the show. I guess should have been [Br]

internal/xray/tree_node.go Outdated Show resolved Hide resolved
internal/view/helpers_test.go Show resolved Hide resolved
change_logs/release_v0.14.0.md Show resolved Hide resolved
change_logs/release_0.8.0.md Show resolved Hide resolved
@@ -16,7 +16,7 @@ On Slack? Please join us [K9slackers](https://join.slack.com/t/k9sers/shared_inv

And now for something a `beat` different?

I figured, why not share one of the tunes I was spinning when powering thru teh bugs? Might as well share the pain/pleasure roaght?
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well this is for fun - usually write the release docs late at night so a little liberty is in order...

change_logs/release_v0.20.0.md Outdated Show resolved Hide resolved
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@derailed derailed merged commit a07243d into derailed:master Apr 27, 2021
@jsoref jsoref deleted the spelling branch April 27, 2021 16:01
placintaalexandru pushed a commit to placintaalexandru/k9s that referenced this pull request Apr 3, 2024
* spelling: a hex

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: accepted

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: actions

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: additional

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: assertions

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: assessments

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: betta'

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: [br]eaking [ba]d

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: change

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: changed

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: childnodes

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: cleared

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: clusterrole

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: collection

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: columns

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: configuration

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: confirm

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: consensus

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: crumbs

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: ctrl

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: ctx

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: debugging

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: deltas

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: deprecated

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: describable

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: disturbance

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: disturbances

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: efforts

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: excitement

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: filter

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: forward

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: forwarding

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: fqn

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: fullscreen

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: grab

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: graphable

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: groups if

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: homebrew

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: hopeful

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: impatient

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: initialized

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: initially

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: is a

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: job runner

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: kubectl

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: kubernetes

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: latest

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: list

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: makusi

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: menu

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: mnemonic

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: nice

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: nominally

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: nonexistent

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: original

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: outputs

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: override

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: parens

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: preceded

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: preliminary

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: process

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: prozac

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: purpose

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: rbac

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: repeatedly

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: replenishing

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: resource

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: returns

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: right

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: row event

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: rpi

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: salient

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: seemingly

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: separator

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: shas

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: shortcut

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: shortcuts

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: solidify

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: sponsorship

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: superfluous

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: support

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: target's

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: threshold

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: times out

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: tripping

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: unanimous (?)

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: upgrade

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: using

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: views

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: vulnerability

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

* spelling: will launch

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants