-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling #1089
Spelling #1089
Conversation
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@@ -16,9 +16,9 @@ Also if you dig this tool, please make some noise on social! [@kitesurfer](https | |||
|
|||
I always seem to get this wrong... Does Labor Day weekend mean you get to work on your OSS projects all weekend? | |||
|
|||
I am very excited about this drop and hopefully won't be hunamimous on this? 🐭 | |||
I am very excited about this drop and hopefully won't be unanimous (?) on this? 🐭 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@derailed: I'm not at all certain about this.
@@ -14,7 +14,7 @@ On Slack? Please join us [K9slackers](https://join.slack.com/t/k9sers/shared_inv | |||
|
|||
## 🙀(PLUGIN-19) | |||
|
|||
[BR]eaking bad on K9s plugins! In previous releases, we used the COL<INDEX> semantic to reference view column data in the plugin extensions. In this drop, we've axed this in favor of column name vs column index. This makes K9s plugin more readable and usable. Also, in light of custom columns, this old semantic just did not jive to well. To boot, all columns available on the viewed resource, regardless of display preferences or order are now free game to plugin authors. So for folks currently leveraging K9s plugins, this drop will break you I am hopeful you guys dig this approach betta?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the show. I guess should have been [Br]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want [Br]eaking [Ba]d
-- totally happy to do this.
Amusingly, betta here should really be beta
(the former is a genus of 🐟 ).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went with betta'
to match a similar instance. Although I'm going to have to consider adding betta
to my list of "not words you want to use", since I suspect on average it's a typo of something.
@@ -16,7 +16,7 @@ On Slack? Please join us [K9slackers](https://join.slack.com/t/k9sers/shared_inv | |||
|
|||
And now for something a `beat` different? | |||
|
|||
I figured, why not share one of the tunes I was spinning when powering thru teh bugs? Might as well share the pain/pleasure roaght? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're attached to these spellings, I can trivially drop individual commits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well this is for fun - usually write the release docs late at night so a little liberty is in order...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Josh - inside humor likely no one gets - so do make it right
!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR Josh! As for myself, shorter prs make me happy...
...and there I was thinking I was a great speller. Time to re-install the ever so annoying spell checker ;(
@@ -14,7 +14,7 @@ On Slack? Please join us [K9slackers](https://join.slack.com/t/k9sers/shared_inv | |||
|
|||
## 🙀(PLUGIN-19) | |||
|
|||
[BR]eaking bad on K9s plugins! In previous releases, we used the COL<INDEX> semantic to reference view column data in the plugin extensions. In this drop, we've axed this in favor of column name vs column index. This makes K9s plugin more readable and usable. Also, in light of custom columns, this old semantic just did not jive to well. To boot, all columns available on the viewed resource, regardless of display preferences or order are now free game to plugin authors. So for folks currently leveraging K9s plugins, this drop will break you I am hopeful you guys dig this approach betta?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per the show. I guess should have been [Br]
@@ -16,7 +16,7 @@ On Slack? Please join us [K9slackers](https://join.slack.com/t/k9sers/shared_inv | |||
|
|||
And now for something a `beat` different? | |||
|
|||
I figured, why not share one of the tunes I was spinning when powering thru teh bugs? Might as well share the pain/pleasure roaght? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well this is for fun - usually write the release docs late at night so a little liberty is in order...
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: a hex Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: accepted Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: actions Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: additional Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: assertions Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: assessments Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: betta' Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: [br]eaking [ba]d Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: change Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: changed Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: childnodes Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: cleared Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: clusterrole Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: collection Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: columns Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: configuration Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: confirm Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: consensus Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: crumbs Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: ctrl Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: ctx Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: debugging Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: deltas Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: deprecated Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: describable Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: disturbance Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: disturbances Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: efforts Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: excitement Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: filter Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: forward Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: forwarding Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: fqn Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: fullscreen Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: grab Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: graphable Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: groups if Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: homebrew Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: hopeful Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: impatient Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: initialized Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: initially Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: is a Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: job runner Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: kubectl Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: kubernetes Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: latest Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: list Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: makusi Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: menu Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: mnemonic Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: nice Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: nominally Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: nonexistent Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: original Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: outputs Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: override Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: parens Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: preceded Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: preliminary Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: process Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: prozac Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: purpose Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: rbac Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: repeatedly Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: replenishing Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: resource Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: returns Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: right Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: row event Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: rpi Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: salient Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: seemingly Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: separator Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: shas Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: shortcut Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: shortcuts Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: solidify Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: sponsorship Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: superfluous Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: support Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: target's Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: threshold Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: times out Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: tripping Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: unanimous (?) Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: upgrade Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: using Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: views Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: vulnerability Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: will launch Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at jsoref@2b01b10#commitcomment-49586199
The action reports that the changes in this PR would make it happy: jsoref@d659b02