feat(delete/node): challenge deletion by text phrase

README.md

@@ -436,6 +436,8 @@ K9s uses aliases to navigate most K8s resources.
         memory: 100Mi
       # Enable TTY
       tty: true
+    # When enabled adds extra input field in which you have to confirm the deletion of a node
+    idiotLight: false
   ```
 
 ---

cmd/root.go

@@ -244,6 +244,13 @@ func initK9sFlags() {
 		"",
 		"Sets a path to a dir for a screen dumps",
 	)
+	rootCmd.Flags().BoolVar(
+		k9sFlags.IdiotLight,
+		"idiot-light",
+		false,
+		"Enable idiot light to warn the user for potentially destructive operations, e.g., delete a node",
+	)
+
 	rootCmd.Flags()
 }
 

internal/config/flags.go

@@ -27,6 +27,7 @@ type Flags struct {
 	Write         *bool
 	Crumbsless    *bool
 	ScreenDumpDir *string
+	IdiotLight    *bool
 }
 
 // NewFlags returns new configuration flags.
@@ -43,6 +44,7 @@ func NewFlags() *Flags {
 		Write:         boolPtr(false),
 		Crumbsless:    boolPtr(false),
 		ScreenDumpDir: strPtr(AppDumpsDir),
+		IdiotLight:    boolPtr(false),
 	}
 }
 

internal/config/k9s.go

@@ -28,11 +28,13 @@ type K9s struct {
 	ImageScans          ImageScans `json:"imageScans" yaml:"imageScans"`
 	Logger              Logger     `json:"logger" yaml:"logger"`
 	Thresholds          Threshold  `json:"thresholds" yaml:"thresholds"`
+	IdiotLight          bool       `json:"idiotLight" yaml:"idiotLight"`
 	manualRefreshRate   int
 	manualHeadless      *bool
 	manualLogoless      *bool
 	manualCrumbsless    *bool
 	manualReadOnly      *bool
+	manualIdiotLight    *bool
 	manualCommand       *string
 	manualScreenDumpDir *string
 	dir                 *data.Dir
@@ -99,6 +101,7 @@ func (k *K9s) Merge(k1 *K9s) {
 	k.ShellPod = k1.ShellPod
 	k.Logger = k1.Logger
 	k.ImageScans = k1.ImageScans
+	k.IdiotLight = k1.IdiotLight
 	if k1.Thresholds != nil {
 		k.Thresholds = k1.Thresholds
 	}
@@ -249,9 +252,11 @@ func (k *K9s) Override(k9sFlags *Flags) {
 
 	k.manualHeadless = k9sFlags.Headless
 	k.manualLogoless = k9sFlags.Logoless
+	k.manualIdiotLight = k9sFlags.IdiotLight
 	k.manualCrumbsless = k9sFlags.Crumbsless
 	if k9sFlags.ReadOnly != nil && *k9sFlags.ReadOnly {
 		k.manualReadOnly = k9sFlags.ReadOnly
+
 	}
 	if k9sFlags.Write != nil && *k9sFlags.Write {
 		var false bool
@@ -310,6 +315,15 @@ func (k *K9s) IsReadOnly() bool {
 	return ro
 }
 
+func (k *K9s) HasIdiotLight() bool {
+	idiotLight := k.IdiotLight
+	if k.manualIdiotLight != nil {
+		idiotLight = *k.manualIdiotLight
+	}
+
+	return idiotLight
+}
+
 // Validate the current configuration.
 func (k *K9s) Validate(c client.Connection, ks data.KubeSettings) {
 	if k.RefreshRate <= 0 {

internal/ui/dialog/delete.go

@@ -4,6 +4,8 @@
 package dialog
 
 import (
+	"fmt"
+
 	"github.com/derailed/k9s/internal/config"
 	"github.com/derailed/k9s/internal/ui"
 	"github.com/derailed/tview"
@@ -28,7 +30,7 @@ var propagationOptions []string = []string{
 }
 
 // ShowDelete pops a resource deletion dialog.
-func ShowDelete(styles config.Dialog, pages *ui.Pages, msg string, ok okFunc, cancel cancelFunc) {
+func ShowDelete(styles config.Dialog, pages *ui.Pages, msg string, ok okFunc, cancel cancelFunc, challenge string) {
 	propagation, force := "", false
 	f := tview.NewForm()
 	f.SetItemPadding(0)
@@ -48,11 +50,25 @@ func ShowDelete(styles config.Dialog, pages *ui.Pages, msg string, ok okFunc, ca
 	f.AddCheckbox("Force:", force, func(_ string, checked bool) {
 		force = checked
 	})
+
+	confirmCheck := ""
+	if challenge != "" {
+		f.AddInputField(fmt.Sprintf("Confirm with: \"%s\":", challenge), confirmCheck, 30, nil, func(text string) {
+			confirmCheck = text
+		})
+	}
+
 	f.AddButton("Cancel", func() {
 		dismiss(pages)
 		cancel()
 	})
+
 	f.AddButton("OK", func() {
+		if challenge != "" && confirmCheck != challenge {
+			cancel()
+			return
+		}
+
 		switch propagation {
 		case noDeletePropagation:
 			ok(nil, force)

internal/ui/dialog/delete_test.go

@@ -23,7 +23,7 @@ func TestDeleteDialog(t *testing.T) {
 	caFunc := func() {
 		assert.True(t, true)
 	}
-	ShowDelete(config.Dialog{}, p, "Yo", okFunc, caFunc)
+	ShowDelete(config.Dialog{}, p, "Yo", okFunc, caFunc, "")
 
 	d := p.GetPrimitive(dialogKey).(*tview.ModalForm)
 	assert.NotNil(t, d)

internal/view/browser.go

@@ -356,7 +356,13 @@ func (b *Browser) deleteCmd(evt *tcell.EventKey) *tcell.EventKey {
 			b.simpleDelete(selections, msg)
 			return nil
 		}
-		b.resourceDelete(selections, msg)
+
+		challenge := ""
+		if b.App().Config.K9s.HasIdiotLight() && b.GVR().R() == "nodes" {
+			challenge = "delete!"
+		}
+
+		b.resourceDelete(selections, msg, challenge)
 	}
 
 	return nil
@@ -577,7 +583,7 @@ func (b *Browser) simpleDelete(selections []string, msg string) {
 	}, func() {})
 }
 
-func (b *Browser) resourceDelete(selections []string, msg string) {
+func (b *Browser) resourceDelete(selections []string, msg string, challenge string) {
 	okFn := func(propagation *metav1.DeletionPropagation, force bool) {
 		b.ShowDeleted()
 		if len(selections) > 1 {
@@ -599,5 +605,5 @@ func (b *Browser) resourceDelete(selections []string, msg string) {
 		}
 		b.refresh()
 	}
-	dialog.ShowDelete(b.app.Styles.Dialog(), b.app.Content.Pages, msg, okFn, func() {})
+	dialog.ShowDelete(b.app.Styles.Dialog(), b.app.Content.Pages, msg, okFn, func() {}, challenge)
 }

internal/view/workload.go

@@ -151,7 +151,7 @@ func (w *Workload) resourceDelete(selections []string, msg string) {
 		}
 		w.GetTable().Start()
 	}
-	dialog.ShowDelete(w.App().Styles.Dialog(), w.App().Content.Pages, msg, okFn, func() {})
+	dialog.ShowDelete(w.App().Styles.Dialog(), w.App().Content.Pages, msg, okFn, func() {}, "")
 }
 
 func (w *Workload) describeCmd(evt *tcell.EventKey) *tcell.EventKey {

internal/view/xray.go

@@ -693,7 +693,7 @@ func (x *Xray) resourceDelete(gvr client.GVR, spec *xray.NodeSpec, msg string) {
 			x.app.factory.DeleteForwarder(spec.Path())
 		}
 		x.Refresh()
-	}, func() {})
+	}, func() {}, "")
 }
 
 // ----------------------------------------------------------------------------