try to get the os name form the pod assigned node #2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @derailed, thanks for the quick feedback, what do you think of the changes now? BTW, the k9s is a great project and it has helped me very much at work, so I hope it gets a little better! |
derailed
reviewed
Nov 10, 2023
|
@wjiec Thank you for your kind words! You are a stand up guy!! |
|
I'm a bad talker, so let's make k9s even better! 😊 |
|
any nitpicks are okay, I'm a perfectionist too, and I look forward to hearing from you. |
derailed
added a commit
that referenced
this pull request
Nov 12, 2023
* get the os name from the node when needed * code quality * remove err sentinel --------- Co-authored-by: Fernand Galiana <fernand.galiana@gmail.com>
thejoeejoee
pushed a commit
to thejoeejoee/k9s
that referenced
this pull request
Feb 23, 2024
* get the os name from the node when needed * code quality * remove err sentinel --------- Co-authored-by: Fernand Galiana <fernand.galiana@gmail.com>
placintaalexandru
pushed a commit
to placintaalexandru/k9s
that referenced
this pull request
Apr 3, 2024
* get the os name from the node when needed * code quality * remove err sentinel --------- Co-authored-by: Fernand Galiana <fernand.galiana@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR fixes #2281.