ensure kubeclient ns is release ns for helm actions #2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derailed
reviewed
Apr 20, 2024
thorbenbelow
commented
Apr 20, 2024
Signed-off-by: Thorben Below <56894536+thorbenbelow@users.noreply.github.com>
thorbenbelow
force-pushed
the
fix/helm-client-ns
branch
from
6064dc4
to
3cc1a32
Compare
|
Hello all, when will this PR get merged? It can cause huge problems. |
|
Hey @derailed, are you missing something in this PR for it to be mergeable? |
|
Don't want to start a dogpile here, but this bug also manifests in how Helm rollbacks works, it appears, and has caused a production incident for us in the past using k9s. Would love to see this fixed. |
derailed
approved these changes
Aug 16, 2024
uozalp
pushed a commit
to uozalp/k9s
that referenced
this pull request
Sep 2, 2024
Signed-off-by: Thorben Below <56894536+thorbenbelow@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2634
Also looks like this is the same issue as with #1033
From my understanding helm will use the namespace from
flagsto determine where it runs actions. Imo this should always be the release namespace.