Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jump to namespaceless owner reference #2718

Merged
merged 1 commit into from
May 26, 2024

Conversation

gitolicious
Copy link
Contributor

@gitolicious gitolicious commented May 24, 2024

#2700 introduced navigation to resource owners. Navigating to namespaceless owners like nodes failed though.
This fixes the navigation by checking if the owner is namespaced.

Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gitolicious Good catch. Thank you!

@derailed derailed merged commit 9594065 into derailed:master May 26, 2024
3 checks passed
@derailed derailed mentioned this pull request Jun 15, 2024
rm-hull added a commit to rm-hull/k9s that referenced this pull request Aug 12, 2024
* 'master' of github.com:derailed/k9s: (169 commits)
  fix: align build image Go version with go.mod (derailed#2812)
  Bump github.com/docker/docker (derailed#2816)
  Bump golangci/golangci-lint-action from 6.0.1 to 6.1.0 (derailed#2813)
  Add comment about Escape keybinding (derailed#2817)
  proper handle OwnerReference for manually created job (derailed#2772)
  [derailed#2773] fix freebsd build failure (derailed#2775)
  install copyright file into correct location (derailed#2780)
  fix status for completed pods in workload view (derailed#2729)
  update deps
  [Maint] Bump grype rev
  K9s/release v0.32.5 (derailed#2740)
  --- (derailed#2707)
  fix view sorting being reset (derailed#2736)
  use policy/v1 instead of policy/v1beta1 (derailed#2732)
  Bump alpine from 3.19.1 to 3.20.0 (derailed#2721)
  fix: jump to namespaceless owner reference (derailed#2718)
  feat: Add plugins for argo-rollouts (derailed#2711)
  Bump golangci/golangci-lint-action from 5.1.0 to 6.0.1 (derailed#2702)
  allow jumping to the owner of the resource (derailed#2700)
  fix: job color based on failures (derailed#2686) (derailed#2698)
  ...
thorbenbelow pushed a commit to thorbenbelow/k9s that referenced this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants