feat(sort): allow sorting any column with top like navigation #2739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@derailed Any feedback on this? Since this is a long standing issue with a previous PR, if the proposed implementation is bad in any way, please provide some insights on how we should go on implementing it. As it is really useful to be able to sort by any column quickly. |
|
@ventsislav-georgiev I think this feature is great. Let's resolve the conflict and I'll take a peek... |
ventsislav-georgiev
force-pushed
the
sort-on-any-column
branch
from
2a2c1ff to
2a46d90
Compare
|
@derailed Thanks, conflict resolved. |
|
ping @derailed |
ventsislav-georgiev
force-pushed
the
sort-on-any-column
branch
from
2a46d90 to
1fa9c61
Compare
|
@derailed Any chance we could merge this? |
|
@ventsislav-georgiev Looks like we have conflicts. Can you take a peek? |
ventsislav-georgiev
force-pushed
the
sort-on-any-column
branch
2 times, most recently
from
5d56d01 to
a3c7948
Compare
ventsislav-georgiev
force-pushed
the
sort-on-any-column
branch
from
a3c7948 to
08d8cbc
Compare
|
@derailed rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the PR from @mlosicki #1256
Related to: #1000