Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should switching ctx before ns #2750

Merged
merged 1 commit into from
Aug 16, 2024
Merged

fix: should switching ctx before ns #2750

merged 1 commit into from
Aug 16, 2024

Conversation

wjiec
Copy link
Contributor

@wjiec wjiec commented Jun 18, 2024

this PR fixes #2747.

derailed
derailed approved these changes Aug 16, 2024
View reviewed changes
Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wjiec Doh! Nice catch. Thank you Jayson!!

@derailed derailed merged commit 4b2111e into derailed:master Aug 16, 2024
2 of 3 checks passed
@wjiec wjiec deleted the bugfix/ctx-ns-switching branch August 16, 2024 01:45
uozalp pushed a commit to uozalp/k9s that referenced this pull request Sep 2, 2024
@wjiec @uozalp
should switching ctx before ns (derailed#2750)
c73b97c
thorbenbelow pushed a commit to thorbenbelow/k9s that referenced this pull request Nov 10, 2024
@wjiec @thorbenbelow
should switching ctx before ns (derailed#2750)
7897f2a
@derailed derailed mentioned this pull request Nov 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derailed derailed derailed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Combining context and namespace switching only works sporadically (e.g. ":pod foo-ns @ctx-dev")
2 participants
@wjiec @derailed