enter replicasets from deployments #3001
Conversation
There was a problem hiding this comment.
@rudrakhp Nice!
I don't think i can review the code, so i will keep it for @derailed 😄 .
IMO, you're right that the replicaset makes more sense on enter press than the pod list. But, we should keep the pod behavior in a different shortcut (like P key if not used) and not removing it. I'm sure it's being used.
Side note, in any case we need to update the docs on the new logic
|
I think the |
There was a problem hiding this comment.
@rudrakhp Thank you for this PR! Tho technically this is correct, I don't think we should alter the current behavior as this was a conscious decision to get to the pertinent information quickly aka show me the latest incarnation of the pods associated with this deployment.
That said, I think it makes sense to nav dp->rs so users can see the various versions at stake.
derailed
added
enhancement
|
@rudrakhp Also the tests need some TLC |
rudrakhp
force-pushed
the
dp_enter_rs
branch
from
22003ed to
0fb7066
Compare
|
@derailed somehow this slipped my mind, updated the PR, do check! |
rudrakhp
force-pushed
the
dp_enter_rs
branch
from
0fb7066 to
cdbd848
Compare
internal/view/dp.go
Outdated
| @@ -47,6 +47,7 @@ func (d *Deploy) bindKeys(aa *ui.KeyActions) { | |||
| ui.KeyShiftR: ui.NewKeyAction("Sort Ready", d.GetTable().SortColCmd(readyCol, true), false), | |||
| ui.KeyShiftU: ui.NewKeyAction("Sort UpToDate", d.GetTable().SortColCmd(uptodateCol, true), false), | |||
| ui.KeyShiftL: ui.NewKeyAction("Sort Available", d.GetTable().SortColCmd(availCol, true), false), | |||
| ui.KeyR: ui.NewKeyAction("Show Replicasets", d.replicaSetsCmd, true), | |||
There was a problem hiding this comment.
We need another key here as r is already allocated to restart.
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
rudrakhp
force-pushed
the
dp_enter_rs
branch
from
cdbd848 to
39a413a
Compare
Fixes #2951
Today on entering a deployment, pods associated with it are listed. Changed behaviour to list replicasets instead. Entering replicaset will list the related pods.
Ran
make build && ./execs/k9son a test cluster to validate behaviour.