Use eslint instead of jshint #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericyhwang
approved these changes
Oct 6, 2022
lib/textDiff.js
Outdated
| @@ -2,20 +2,18 @@ exports.onStringInsert = onStringInsert; | |||
| exports.onStringRemove = onStringRemove; | |||
| exports.onTextInput = onTextInput; | |||
|
|
|||
| function onStringInsert(el, previous, index, text) { | |||
| function onStringInsert(el, previous = '', index, text) { | |||
There was a problem hiding this comment.
Let's not use a default param here, to keep ES5 compatibility for now, and to make for easier future TS conversion.
if (!previous) {
previous = '';
}
lib/textDiff.js
Outdated
| var newText = previous.slice(0, index) + text + previous.slice(index); | ||
| replaceText(el, newText, transformCursor); | ||
| } | ||
|
|
||
| function onStringRemove(el, previous, index, howMany) { | ||
| function onStringRemove(el, previous = '', index, howMany) { |
lib/eventmodel.js
Outdated
| @@ -257,7 +257,9 @@ EventModel.prototype._removeItemContext = function(context) { | |||
|
|
|||
| EventModel.prototype._addBinding = function(binding) { | |||
| var bindings = this.bindings || (this.bindings = new BindingsMap()); | |||
| binding.eventModels || (binding.eventModels = new EventModelsMap()); | |||
| if (bindings.eventModel == null) { | |||
| binding.eventModels = new EventModelsMap() | |||
lib/files.js
Outdated
| @@ -54,7 +54,9 @@ function loadViewsSync(app, sourceFilename, namespace) { | |||
| } | |||
|
|
|||
| function loadStylesSync(app, sourceFilename, options) { | |||
| options || (options = {compress: util.isProduction}); | |||
| if (options == null) { | |||
| options = { compress: util.isProduction } | |||
ericyhwang
reviewed
Oct 25, 2022
| @@ -257,7 +257,9 @@ EventModel.prototype._removeItemContext = function(context) { | |||
|
|
|||
| EventModel.prototype._addBinding = function(binding) { | |||
| var bindings = this.bindings || (this.bindings = new BindingsMap()); | |||
| binding.eventModels || (binding.eventModels = new EventModelsMap()); | |||
| if (bindings.eventModel == null) { | |||
There was a problem hiding this comment.
This should actually be:
if (binding.eventModels == null) {Issue was caught by internal tests when testing derby-2 branch. I'll try and write a more minimal test in the Derby tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslintrcrules converted fromjshintrcvia polyjuice==checks withnullas this effective fornullorundefinedcheckschecksscript combining bothlintandtesteslint --fixfor simple issues (formatting, commas etc)