Add behavioral test for binding bug with view function calls on array items #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of moving to ESLint in the derby-2 branch, there was refactoring that introduced an issue with view functions using array items as one of many arguments, e.g.
viewFn(#item, someOtherPath):https://github.com/derbyjs/derby/pull/604/files#diff-466e85435a395f659e185303f111e9c7a0e4dd4f3e08400eed586fabb0814141R260
The bug was fixed in ba742f6.
This adds a behavioral binding test that failed without the bugfix, and now passes with the bugfix included.
I'm not entirely certain how the presence of the second param triggered the bug. I suspect it's something related to the dependency structure being different with two+ params instead of just one param.