Add better integration methods to App #618
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding derby-webpack to the ecosystem highlighted some rough edges in setup with the existing API.
writeScripts
needed to be called, even if no scripts were boing written by derby, just to install listeners for app refreshbackend.modelMiddleware()
needed to be added to the express app, or derby would default to creating a new model that lacked a connection, so was broken (will look into this separately)Solutions
app.initAutoRefresh(backend)
to setup listeners (better naming, not calling obtuse or private method)app.middleware(backend)
method as obvious express integration point that sets up both the model and the router. If other middlewares is needed, existing methodsbackend.modelMiddleware()
andapp.router()
are still available to add individually.