Change to use everyMinutes trigger for sync #152
Conversation
Instead of re-setting 'install' script every time, just set an "everyMinutes" trigger of the sync method.
|
Thanks for your suggestion. We had this originally but it's restricted to certain inputs (eg 1, 5, 10, 15, etc) and our solution allowed any number you desired (eg run every 7 minutes) and possibly some other improvements (can't remember). But #137 is definitely a problem (Google's problem, not ours) and stability may be more important. @jonas0b1011001 thoughts? |
|
I don't know what the best option is, but waiting for google to fix the issue might be the worst. We can go back to the 'old' method, add a setting to use the old method for those that have issues (as this seems to not happen to everyone) or add another check to see if install was successful (as already described here). |
|
Ah, I like the idea of having the flag in the settings for those of us having this problem but allowing the newer method for those that don't. |
|
Yes please let's count on Google's recurrent triggers! Had problems like #137 and trying to figure out the cause is confusing. Google trigger + a system for notifying fails will make this app much more dependable even if it means triggers are less frequent than desired. |
|
Perhaps for people wanting to sync every 7 minutes, a LastRun conditional can be incorporated to enforce this while the Google trigger is everyMinute. |
Setting the default return value to 15 minutes if the "origFrequency" isn't specified.
Co-authored-by: jonas0b1011001 <43352574+jonas0b1011001@users.noreply.github.com>
Code.gs
Outdated
| throw "[ERROR] \"howFrequent\" must be greater than 0."; | ||
| } | ||
| else{ | ||
| ScriptApp.newTrigger("install").timeBased().after(howFrequent * 60 * 1000).create();//Schedule next Execution | ||
| ScriptApp.newTrigger("startSync").timeBased().everyMinutes(getValidTriggerFrequency(howFrequent)).create(); //Schedule sync routine to explicitly repeat | ||
| ScriptApp.newTrigger("startSync").timeBased().after(1000).create();//Start the sync routine | ||
| } |
There was a problem hiding this comment.
With the previous change, the if statement is no longer needed at this point. Please remove it leaving only the trigger creations. After that i think we are good to go.
Helpers.gs
Outdated
| Logger.log("No valid frequency specified. Defaulting to 15 minutes."); | ||
| return 15; | ||
| } | ||
|
|
There was a problem hiding this comment.
Please remove the excessive new line, helpers.gs is quite long already :)
Input validation for the field was moved into new helper function getValidTriggerFrequency()
Instead of re-setting 'install' script every time, just set an "everyMinutes" trigger of the sync method. Fixes #137