Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix recurrence exception handling #373

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Conversation

jonas0b1011001
Copy link
Collaborator

  • convertToZone(ICAL.TimezoneService.get('UTC')) obviously does not work reliably. Replaced with custom calculation/conversion.
  • Recurrence exception were added even though addEventsToCalendar = false

@jonas0b1011001 jonas0b1011001 marked this pull request as ready for review October 1, 2023 17:01
@derekantrican
Copy link
Owner

convertToZone(ICAL.TimezoneService.get('UTC')) obviously does not work reliably

Is there an open bug for this on the ICAL.js repo? Or are we just behind?

@jonas0b1011001
Copy link
Collaborator Author

We actually are a version behind, the issue however seems to be a known limitation, the readme states:

The stock ical.js does not register any timezones, due to the additional size it brings. If you'd like to do timezone conversion, and the timezone definitions are not included in the respective ics files, you'll need to use ical.timezones.js or its minified counterpart.

@derekantrican derekantrican merged commit f88b3d0 into master Dec 13, 2023
1 check passed
@jonas0b1011001 jonas0b1011001 deleted the jonas0b1011001-recurrence-id branch February 16, 2024 12:36
jonas0b1011001 added a commit that referenced this pull request May 22, 2024
* recurrence exception fix

attempt to fix recurrence issue from discord

* Respect modifyExistingEvents and addEventsToCalendar setting in processEventInstance()

* Skip of no tz is specified
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants