Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix horizontal gaps in montage mode #673

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

qustrolabe
Copy link

There are black horizontal 5px wide stripes between rows in montage mode. This happens because there are additional 5px added to height for index mode text.

text_area_h = fh + 5;
tot_thumb_h = opt.thumb_h + text_area_h;

These gaps definitely shouldn't appear in montage mode as no text being printed there, and it makes usage of --limit-height flag hard because of 5px added every row.

Fixed by adding condition to add text_area_h to tot_thumb_h only in index mode.

Example with 4 separate images --thumb-width 256 --thumb-height 256 --limit-width 512
Before:
before
After:
after

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant