options should not be prepended with 'master' or 'slave'. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is breaking functionality on at least CentOS7
|
also if I should pull against the 'dev' branch please just let me know |
|
Property prefixing was introduced in order to avoid conflicts between properties with the same name (see #45). This patch would break such behavior, we have to find a better way how to fix this. |
|
ahhhh, i see... so you have to prepend to allow the property but then strip it when you create the property resource. i hadn't run into that as i'm not running slaves on my masters. i'll take a look today and see what i can do. i figured my fix was naive, i just wanted to explain the problem some more, code always helps me. |
|
I'm closing this as it doesn't seem to be the right solution for the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue reported in #66 where options stored in /etc/mesos-master and /etc/mesos-slave were being prepended with
master_andslave_which was breaking functionality with/usr/bin/mesos-init-wrapperbecause it sends options as--master_hostnameas opposed tohostnamefor instance.i'm not sure how or why this is not affecting any other users of this module, so this code may be irrelevant and I may just be looking for clarification on why my setup is not working out of the box.