fix: add user ip to growthbook options #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amam-deriv
requested review from
ali-hosseini-deriv and
prince-deriv
as code owners
habib-deriv
reviewed
Sep 9, 2024
src/analytics.ts
Outdated
| } | ||
| growthbookOptions ??= {} | ||
| growthbookOptions.attributes ??= {} | ||
| growthbookOptions.attributes.id ??= _rudderstack.getAnonymousId() | ||
| growthbookOptions.attributes.country ??= | ||
| Cookies.get('clients_country') || | ||
| (Cookies as any).getJSON('website_status')?.clients_country || | ||
| Cookies.getJSON('website_status')?.clients_country || |
There was a problem hiding this comment.
Property 'getJSON' does not exist on type 'CookiesStatic & { noConflict?(): CookiesStatic; }'.
We'll need as any ?
amam-deriv
force-pushed
the
amam/add-userip
branch
from
9f40039
to
eac0b13
Compare
habib-deriv
approved these changes
Sep 9, 2024
| @@ -57,6 +57,7 @@ export function createAnalyticsInstance(options?: Options) { | |||
| device_type: growthbookOptions?.attributes.device_type, | |||
| }), | |||
| ...(growthbookOptions?.attributes?.url && { url: growthbookOptions?.attributes.url }), | |||
| ...(growthbookOptions?.attributes?.user_ip && { url: growthbookOptions?.attributes.user_ip }), | |||
There was a problem hiding this comment.
This can be fall under privacy policy
As such, organizations processing IP addresses must adhere to the strict regulations on data protection and privacy. Under the GDPR, when an IP address is collected and processed, it is treated with the same level of protection as any other personal data, such as names, addresses, or social security numbers.
Need to confirm with the compliance before we proceed with this.
There was a problem hiding this comment.
cloudflare by default also collect user ip address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
user ip is a needed ip address attribute to filter office ips and also blacklist/whitelist ip
Changes