Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TRAH] Sergei / TRAH 3103 / Add type for performance metrics #51

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[TRAH] Sergei / TRAH 3103 / Add type for performance metrics #51

wants to merge 3 commits into from

Conversation

sergei-deriv
Copy link

Add type for performance metrics

review-deriv
review-deriv reviewed Apr 1, 2024
View reviewed changes
Copy link

@review-deriv review-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR description is too short. You can use this format:

# Description
This is a summary of the changes. This should describe why do we need this change.
Whys and Hows come here.

# Cards
* https://clickup.com/12345
* https://clickup.com/12346

@sergei-deriv sergei-deriv force-pushed the sergei/add-type-for-performance branch from 8316384 to b3f8674 Compare April 1, 2024 14:03
NikitK-deriv
NikitK-deriv reviewed Apr 2, 2024
View reviewed changes
Copy link
Contributor

@NikitK-deriv NikitK-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update a package version to have a possibility to publish on npm

@sergei-deriv sergei-deriv force-pushed the sergei/add-type-for-performance branch 2 times, most recently from 4da7894 to f66d0c3 Compare April 4, 2024 12:19
@sergei-deriv sergei-deriv force-pushed the sergei/add-type-for-performance branch from f66d0c3 to 6583d21 Compare April 4, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikitK-deriv NikitK-deriv NikitK-deriv left review comments

@review-deriv review-deriv review-deriv left review comments

@mahdiyeh-deriv mahdiyeh-deriv mahdiyeh-deriv approved these changes

@habib-deriv habib-deriv habib-deriv approved these changes

@shahzaib-deriv shahzaib-deriv shahzaib-deriv approved these changes

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv ali-hosseini-deriv is a code owner

@prince-deriv prince-deriv Awaiting requested review from prince-deriv prince-deriv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sergei-deriv @mahdiyeh-deriv @habib-deriv @NikitK-deriv @shahzaib-deriv @review-deriv