DTRA-1569 / Kate / Filter resetting issue #16359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information. |
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-kate-deriv-kate-dtra-1569fixfilterreset.binary.sx/ |
kate-deriv
commented
Aug 5, 2024
| @@ -67,8 +67,14 @@ export default class ProfitTableStore extends BaseStore { | |||
| if (!this.shouldFetchNextBatch(isMounting)) return; | |||
| this.is_loading = true; | |||
| const dateParams = getDateBoundaries(this.date_from, this.date_to, 0, false); | |||
| const dateParamsDTraderV2 = getDateBoundaries( | |||
There was a problem hiding this comment.
When onMount is from profit-store is called, it reset date filters. In order not to lose them, now I'm taking them from positions store
kate-deriv
commented
Aug 5, 2024
kate-deriv
changed the title
maryia-deriv
approved these changes
Aug 5, 2024
maryia-deriv
approved these changes
Aug 5, 2024
ahmadtaimoor-deriv
approved these changes
Aug 5, 2024
akmal-deriv
approved these changes
Aug 5, 2024
…9/fix_filter_reset
|
vinu-deriv
approved these changes
Aug 16, 2024
balakrishna-deriv
approved these changes
Aug 19, 2024
maryia-deriv
approved these changes
Aug 19, 2024
vinu-deriv
merged commit c2d268a
into
deriv-com:position-and-contract-details-fixes
4 checks passed
vinu-deriv
pushed a commit
that referenced
this pull request
Aug 27, 2024
* Ahmad/DTRA-1408/Fix Vanilla Contract in Contract Details V2 (#16018) * fix: decimal point * fix: currency in payoutperpoint * fix: vanillas * fix: only vanilla * fix: test coverage * Ahmad/DTRA-1405/Multipliers fix on Contract Details V2 (#16017) * fix: multiplier * fix: testcase * fix: fix * fix: deal cancel * chore: add DC * chore: suggestion * chore:fix * fix: test case fix * Ahmad/DTRA-1401/DTRA-1402/Add currency in payout per point and decimal point in take profit (#16012) * fix: decimal point * fix: currency in payoutperpoint * fix: vanillas * fix: test case and comments * chore: review fix * fix: indent --------- Co-authored-by: balakrishna-deriv <56330681+balakrishna-deriv@users.noreply.github.com> * fix: bugs with resetting filter and icon for hight low (#16003) Co-authored-by: balakrishna-deriv <56330681+balakrishna-deriv@users.noreply.github.com> * Akmal / fix: pass currency across closed positions and contract details (#16161) * fix: pass currency across closed positions and contract details * fix: add a comment * [DTRA]/Ahmad/DTRA-1490/Deal Cancellation Status Fix Trader-V2 (#16121) * fix: cancellation active, executed and expired * chore: revert last commit * DTRA-1569 / Kate / Filter resetting issue (#16359) * fix: resetting filter issue * refactor: add date clear on unmount * refactor: tests * fix: tests * fix: console error * Akmal / fix: wrong duration unit for digit contracts (#16378) * fix: wrong duration unit for digit contracts * fix: test case * Akmal / fix: take profit & stop loss decimals (#16195) * fix: remove decimals from take profit * fix: apply fixes from quill library * fix: apply dynamic decimal places based on currency * feat: update quill-ui version --------- Co-authored-by: ahmadtaimoor-deriv <129935294+ahmadtaimoor-deriv@users.noreply.github.com> Co-authored-by: kate-deriv <121025168+kate-deriv@users.noreply.github.com> Co-authored-by: Akmal Djumakhodjaev <akmal@binary.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Fixed filter resetting value
Screenshots:
Please provide some screenshots of the change.